Decouple tftp server and switch template #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is 👍 to me, with a little for the PR title: your code should be considered as refactor not to decouple the tftp server & template. |
anhou
force-pushed
the
enhancement/render
branch
from
6acffa8
to
5f192f4
Compare
| API_SERVER_ADDRESS = '<%=apiServerAddress%>' | ||
| API_SERVER_PORT = '<%=apiServerPort%>' | ||
|
|
||
| switch_profile_uri = 'http://{0}:{1}/api/1.1/profiles/switch'.format(API_SERVER_ADDRESS, API_SERVER_PORT) |
There was a problem hiding this comment.
minor: will it be better to use 'current' or 'common' to replace '1.1'
There was a problem hiding this comment.
Just refactor the codes, don't intend to change the logic
|
👍 |
anhou
force-pushed
the
enhancement/render
branch
from
5f192f4
to
5f0e39f
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to rebase after #49 merged
@RackHD/corecommitters @larry-dean