This repository has been archived by the owner on Mar 21, 2019. It is now read-only.
Add pagination support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.73%@@ master #9 diff @@
==========================================
Files 1 2 +1
Lines 21 57 +36
Methods 0 0
Messages 0 0
Branches 1 4 +3
==========================================
+ Hits 20 54 +34
Misses 0 0
- Partials 1 3 +2
|
| [manifold.deferred :as md])) | ||
|
|
||
| (defn paginated->stream | ||
| "Given a resource with pagination semantics, turns it into a single |
There was a problem hiding this comment.
I think this should read "Given a resource with pagination semantics, turn it into a single stream that ..."
There was a problem hiding this comment.
What about "Given a resource with pagination semantics, returns a single stream that ..."
There was a problem hiding this comment.
I think @derwolfe's objection is about person, not the word itself; so that'd be "return", I guess.
There was a problem hiding this comment.
@lvh - you are correct about my objection.
|
LGTM assuming ci passes. |
| an HTTP request). `get-results` is passed that value from `handle-todo`, and | ||
| should return the results in that value. These will be added to the output | ||
| stream. `get-next-todo` should return the next todo or nil if this is the | ||
| last page. `first-todo` is the first todo item to kick this process off." |
There was a problem hiding this comment.
I was just about to ask you to document these parameters. Good stuff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.