Add comment column to ipv4space page #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One obvious issue with this change is that a network comment text may be very wide. This will cause an immediate regression to the table that is used to display the network tree. Another issue is that there is no configuration option to control the new behaviour. |
|
A possible solution to this could be changing the code to only display the comment when explicitly configured by the user, and probably in a separate TR following the TR with the existing network information. |
|
Any existing examples of where a user could configure an option like this? |
|
It should work similar to |
|
Please open a new pull request when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments to the ipv4space page, to quickly locate a particular subnet at a glance.