Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation error message to use min and max values #3

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Update validation error message to use min and max values #3

merged 1 commit into from
Sep 16, 2021

Conversation

cjke
Copy link
Contributor

@cjke cjke commented Jun 15, 2020

:min and :max are never actually substituted in because they aren't params to the rule

@coveralls
Copy link

coveralls commented Jun 15, 2020

Pull Request Test Coverage Report for Build 16

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/BaseMysqlIntegerRule.php 0 1 0.0%
Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 31
Relevant Lines: 45

💛 - Coveralls

@LasseRafn LasseRafn merged commit 63f28d1 into Rackbeat:master Sep 16, 2021
@LasseRafn
Copy link
Contributor

Wow, I missed this one.. Sorry and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants