Merge pull request #106 from bkmetzler/rhel8.6

Use nmcli connection reload to reload ifcfg files for NetworkManager

novaagent/libs/centos.py

@@ -192,12 +192,33 @@ def _restart_network_manager(self):
         :rtype: Popen
         :return: Popen of 'nmcli connection on'
         """
-        # We really don't care if we can't bring it down
-        try:
-            p = Popen(['nmcli', 'networking', 'off'])
-            p.wait()
-        except Exception:
-            pass
+        p = Popen(
+            ['nmcli', 'connection', 'reload'],
+            stdout=PIPE,
+            stderr=PIPE,
+            stdin=PIPE
+        )
+        p.wait()
+        if p.returncode != 0:
+            log.error(
+                "Unable to reload network configurations from ifcfg "
+                "files with 'nmcli connection reload'"
+            )
+            return p
+
+        p = Popen(
+            ['nmcli', 'networking', 'off'],
+            stdout=PIPE,
+            stderr=PIPE,
+            stdin=PIPE
+        )
+        p.wait()
+        if p.returncode != 0:
+            log.error(
+                "Unable to bring down networking with "
+                "'nmcli networking off'"
+            )
+            return p
 
         p = Popen(
             ['nmcli', 'networking', 'on'],