inherit parent div size, dynamic update of subtext & barcolor without redraw #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a bit of a suggested update.
Parent div size: I needed for the knob to be drawn according to CSS size, not the hardcoded size due to the wide range of mobile devices. It's so much easier to detect breakpoints via CSS media and sizing a parent div than detecting every known device and inputing a hard size to ng-knob.
Subtext & barcolor: I've done a tweak to parse whats changed in dynamic options so that elements could be directly updated rather than a complete redraw, this logic could be extended if folk had other attributes they cared about.
Cheers, thanks for an awesome project!