Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to PostCSS 8 and visitors API #95

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RadValentin
Copy link
Owner

@RadValentin RadValentin commented Aug 19, 2021

This PR continues the work done in #93 to make the plugin completely support PostCSS 8 as part of v2.0.0

TODO

  • Find a way to check if file is ignored once per file not once per rule
  • Follow PostCSS plugin guidelines closely
  • Cover all possible atrules in tests
  • Set "postcss": "^8.0.0" as peer and dev dependency
  • Measure performance
  • Consider options argument for transform function

Links

@RadValentin RadValentin changed the title Fix nested postcss selectors not being prefixed Update plugin to PostCSS 8 and visitors API Aug 19, 2021
@eshimischi
Copy link

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :(
for instance, vbenjs/vite-plugin-svg-icons#47

@RadValentin
Copy link
Owner Author

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :( for instance, vbenjs/vite-plugin-svg-icons#47

This PR won't fix the problem in the issue you linked, that's being caused by my plugin requiring a newer version of PostCSS (7 or 8). I can try to see if it will run on PostCSS 5 and publish an update to make the dependency less restrictive. Will take a look at it this weekend.

@RadValentin
Copy link
Owner Author

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :( for instance, vbenjs/vite-plugin-svg-icons#47

I published a new version of the prefixer, it should fix the issues you were mentioning

@windy
Copy link

windy commented May 30, 2022

any updates about this issue?

@RadValentin
Copy link
Owner Author

@windy I don't have time right now for this project. My estimate is that it will be done sometime in July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants