Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

App displays "low exposure" by default if it encounters an error #16

Open
Androp0v opened this issue Sep 10, 2020 · 6 comments
Open

App displays "low exposure" by default if it encounters an error #16

Androp0v opened this issue Sep 10, 2020 · 6 comments

Comments

@Androp0v
Copy link

Androp0v commented Sep 10, 2020

馃攽 It seems to me that the app displays by default a "low exposure" label even if it encounters an error while retrieving the DPT3 exposure status and the exposure status is unknown. From ExpositionUseCase.swift:

case .inactive(let error):
        var errorEI = ExpositionInfo(level: expositionInfoRepository.getExpositionInfo()?.level ?? .healthy)
        errorEI.error = dp3tTracingErrorToDomain(error)
        return errorEI

Also, in this case no value is passed to the lastCheck property of the ExpositionInfo structure, so the app displays a default date of last check "01.07.2020", which is hardcoded in ExpositionViewController:

if let date = self.lastCheck {
    let formatter = DateFormatter()
    formatter.dateFormat = "dd.MM.YYYY"
    return formatter.string(from: date)
}
return "01.07.2020"

This combination makes the app give the impression that it is working even if it's not. In my opinion the app should default to something like "unknown exposure" in case an error is encountered while retrieving the tracing status from DP3T. At the very least the default date of "01.07.2020" should be changed to "Unknown date of last check" (properly localized of course) to better reflect that the app is not actually working. In the current state the app fails silently which could be seen as misleading.

Would you be open to a PR implementing this?

@aalmenar
Copy link

This happens on iOS 14 and 13.7 maybe it鈥檚 related to #4

@Androp0v
Copy link
Author

Androp0v commented Sep 10, 2020

Yes, this happens since iOS 13.7 and iOS 14b6 but should be changed even if/when #4 is fixed in case another issue arises in the future that results in an error when using DPT3. The app should give some kind of warning when it's not working, not default to "low exposure" in case of error.

@aalmenar
Copy link

Yes, both are related and also the error handling should be better than indicating Low Exposure

@JuanpaG94
Copy link

JuanpaG94 commented Sep 13, 2020

Please, this and #4 are REALLY URGENT since the app will not work on iOS 13.7 and iOS 14(it's release is planned for this month) till this is fixed

@Androp0v
Copy link
Author

Androp0v commented Oct 22, 2020

Maybe issues like #35 would be easier to debug if the app didn't default to "low exposure". There's still no way to tell from the app UI if it's working since the app fails silently.

At least the default date of "01.07.2020" is no longer used.

@daronleaj
Copy link

Actually on the app it shows low when no previous state is found, but when last state is risk or infected it shows the correct state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants