-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ref: Refactor tests for better debugging
- almost all tests now aim to tests just one thing. - make namesapce for DRF URLs consistent with that used for django. - change use of raw URLs in the codebase to use url names.
- Loading branch information
1 parent
7677106
commit bdfdea1
Showing
21 changed files
with
1,051 additions
and
660 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| from unittest.mock import patch | ||
|
|
||
| from django.test import RequestFactory | ||
|
|
||
| from comment.tests.test_api.test_views import BaseAPITest | ||
| from comment.api.permissions import ( | ||
| IsOwnerOrReadOnly, FlagEnabledPermission, CanChangeFlaggedCommentState, SubscriptionEnabled, | ||
| CanGetSubscribers) | ||
| from comment.api.views import CommentList | ||
| from comment.models import FlagInstanceManager | ||
| from comment.conf import settings | ||
|
|
||
|
|
||
| class BaseAPIPermissionsTest(BaseAPITest): | ||
| @classmethod | ||
| def setUpTestData(cls): | ||
| super().setUpTestData() | ||
| cls.factory = RequestFactory() | ||
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.view = CommentList() | ||
|
|
||
|
|
||
| class OwnerPermissionTest(BaseAPIPermissionsTest): | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.permission = IsOwnerOrReadOnly() | ||
|
|
||
| def test_get_request(self): | ||
| request = self.factory.get('/') | ||
|
|
||
| self.assertTrue(self.permission.has_object_permission(request, self.view, self.comment_1)) | ||
|
|
||
| def test_put_method_from_different_user(self): | ||
| request = self.factory.put('/') | ||
| request.user = self.user_2 | ||
| self.assertEqual(self.comment_1.user, self.user_1) | ||
|
|
||
| self.assertFalse(self.permission.has_object_permission(request, self.view, self.comment_1)) | ||
|
|
||
| def test_put_method_from_admin(self): | ||
| request = self.factory.put('/') | ||
| request.user = self.admin | ||
| self.assertEqual(self.comment_1.user, self.user_1) | ||
|
|
||
| self.assertFalse(self.permission.has_object_permission(request, self.view, self.comment_1)) | ||
|
|
||
| def test_put_method_from_same_user(self): | ||
| request = self.factory.put('/') | ||
| request.user = self.user_1 | ||
| self.assertEqual(self.comment_1.user, self.user_1) | ||
|
|
||
| self.assertTrue(self.permission.has_object_permission(request, self.view, self.comment_1)) | ||
|
|
||
|
|
||
| class FlagEnabledPermissionTest(BaseAPIPermissionsTest): | ||
| @classmethod | ||
| def setUpTestData(cls): | ||
| super().setUpTestData() | ||
| cls.request = cls.factory.get('/') | ||
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.permission = FlagEnabledPermission() | ||
|
|
||
| @patch.object(settings, 'COMMENT_FLAGS_ALLOWED', 0) | ||
| def test_flagging_disabled(self): | ||
| self.assertIs(False, self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| @patch.object(settings, 'COMMENT_FLAGS_ALLOWED', 1) | ||
| def test_flagging_enabled(self): | ||
| self.assertIs(True, self.permission.has_permission(self.request, self.view)) | ||
|
|
||
|
|
||
| class CanChangeFlaggedCommentStateTest(BaseAPIPermissionsTest): | ||
| @classmethod | ||
| @patch.object(settings, 'COMMENT_FLAGS_ALLOWED', 1) | ||
| def setUpTestData(cls): | ||
| super().setUpTestData() | ||
| cls.flag_data = { | ||
| 'reason': FlagInstanceManager.reason_values[0], | ||
| 'info': '', | ||
| } | ||
| cls.create_flag_instance(cls.user_1, cls.comment_1, **cls.flag_data) | ||
| cls.create_flag_instance(cls.user_2, cls.comment_1, **cls.flag_data) | ||
| cls.comment_1.flag.refresh_from_db() | ||
| cls.flagged_comment = cls.comment_1 | ||
| cls.unflagged_comment = cls.comment_2 | ||
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.permission = CanChangeFlaggedCommentState() | ||
| self.request = self.factory.get('/') | ||
| self.request.user = self.user_1 | ||
|
|
||
| def test_normal_user(self): | ||
| self.assertFalse(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| def test_moderator(self): | ||
| self.request.user = self.moderator | ||
|
|
||
| self.assertTrue(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| def test_moderator_for_unflagged_comment(self): | ||
| self.request.user = self.moderator | ||
|
|
||
| self.assertFalse( | ||
| self.permission.has_object_permission(self.request, self.view, self.unflagged_comment) | ||
| ) | ||
|
|
||
| def test_moderator_for_flagged_comment(self): | ||
| self.request.user = self.moderator | ||
|
|
||
| self.assertIs( | ||
| True, | ||
| self.permission.has_object_permission(self.request, self.view, self.flagged_comment) | ||
| ) | ||
|
|
||
| def test_normal_user_for_flagged_comment(self): | ||
| self.assertIs( | ||
| False, | ||
| self.permission.has_object_permission(self.request, self.view, self.flagged_comment) | ||
| ) | ||
|
|
||
|
|
||
| class CanGetSubscribersTest(BaseAPIPermissionsTest): | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.permission = CanGetSubscribers() | ||
| self.request = self.factory.get('/') | ||
|
|
||
| @patch.object(settings, 'COMMENT_ALLOW_SUBSCRIPTION', True) | ||
| def test_normal_users_cannot_retrieve_subscribers(self): | ||
| self.request.user = self.user_1 | ||
|
|
||
| self.assertFalse(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| @patch.object(settings, 'COMMENT_ALLOW_SUBSCRIPTION', True) | ||
| def test_only_moderators_can_retrieve_subscribers(self): | ||
| self.request.user = self.moderator | ||
|
|
||
| self.assertTrue(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| @patch.object(settings, 'COMMENT_ALLOW_SUBSCRIPTION', False) | ||
| def test_cannot_retrieve_subscribers_when_system_disabled(self): | ||
| self.request.user = self.moderator | ||
|
|
||
| self.assertFalse(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
|
|
||
| class SubscriptionEnabledTest(BaseAPIPermissionsTest): | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.request = self.factory.post('/') | ||
| self.permission = SubscriptionEnabled() | ||
|
|
||
| @patch.object(settings, 'COMMENT_ALLOW_SUBSCRIPTION', False) | ||
| def test_when_subscription_disabled(self): | ||
| self.assertFalse(self.permission.has_permission(self.request, self.view)) | ||
|
|
||
| @patch.object(settings, 'COMMENT_ALLOW_SUBSCRIPTION', True) | ||
| def test_when_permission(self): | ||
| self.assertTrue(self.permission.has_permission(self.request, self.view)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.