Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce testing time in travis #112

Closed
Radi85 opened this issue Dec 6, 2020 · 8 comments
Closed

Reduce testing time in travis #112

Radi85 opened this issue Dec 6, 2020 · 8 comments
Assignees
Labels
Milestone

Comments

@Radi85
Copy link
Owner

Radi85 commented Dec 6, 2020

Change Type

[ ] Refactor/Enhancement
[ ] Testing
[x] CI/CD
[ ] Other

Proposed Changes

Reduce the testing time in travis by reducing the number of python and django compatibility versions.
We can use the most first and most recent version that our app is compatible with.

For python:

  • 3.6
  • 3.8

django:

  • 2.1
  • 3.1
  • django-master
@Radi85 Radi85 added the codebase label Dec 6, 2020
@Radi85 Radi85 added this to the 2.6.0 milestone Dec 6, 2020
@abhiabhi94
Copy link
Collaborator

for documentation specific changes, you may use the [skip ci] in commit message to allow it to pass. This link suggests another option.

Regarding the testing time on travis, someone it does takes a lot of time but this is usually not due to us but something because of them. The tests not take more than 10min to run on all supported versions as of now. I had an email from them that they are going to transfer all repositories to travis-ci.com and the org version will be dead by the end of this year. Maybe that could be a reason.

@abhiabhi94
Copy link
Collaborator

Also, the issue template formatting needs to be updated, I have edited the comment on this one, but it needs to be done in the codebase to be fixed for future.

@Radi85
Copy link
Owner Author

Radi85 commented Dec 6, 2020

for documentation specific changes, you may use the [skip ci] in commit message to allow it to pass. This link suggests another option.

Regarding the testing time on travis, someone it does takes a lot of time but this is usually not due to us but something because of them. The tests not take more than 10min to run on all supported versions as of now. I had an email from them that they are going to transfer all repositories to travis-ci.com and the org version will be dead by the end of this year. Maybe that could be a reason.

Thanks for the info.
In fact why do we need to check the compatibility for every version? What I have mentioned above is enough to cover the versions in between.

@Radi85
Copy link
Owner Author

Radi85 commented Dec 6, 2020

Also, the issue template formatting needs to be updated, I have edited the comment on this one, but it needs to be done in the codebase to be fixed for future.

What needs to be updated?

@abhiabhi94
Copy link
Collaborator

abhiabhi94 commented Dec 6, 2020

What needs to be updated?

you have changed my edit. my version would reflect the to-do list as:

  • Refactor/Enhancement
  • Testing
  • CI/CD
  • Other

while as of now, you can see the to-do list is not rendered correctly.

@Radi85
Copy link
Owner Author

Radi85 commented Dec 6, 2020

What needs to be updated?

you have changed my edit. my version would reflect the to-do list as:

  • Refactor/Enhancement
  • Testing
  • CI/CD
  • Other

while as of now, you can see the to-do list is not rendered correctly.

😄 I have updated it already.

@abhiabhi94
Copy link
Collaborator

Radico's TODO

image

Abhyudai's TODO

image

@Radi85
Copy link
Owner Author

Radi85 commented Dec 6, 2020

Ahhh 😄 , in face this is not a TODO list but just an option of the change type. TODO means that all items should be implemented and this is not the case in issue templates.
Also I list the choices similarly to Github's auto generated issue templates.

@Radi85 Radi85 self-assigned this Dec 6, 2020
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 13, 2020
- also fix some tests that required patching settings.
- reducing time for tox tests by running it for lesser environments(still cover all versions)
- add support for python3.9

fix Radi85#119
fix Radi85#112
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 13, 2020
- also fix some tests that required patching settings.
- reducing time for tox tests by running it for lesser environments(still cover all versions)
- add support for python3.9

fix Radi85#119
fix Radi85#112
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 13, 2020
- also fix some tests that required patching settings.
- reducing time for tests running on travis by running them for lesser environments(still cover all versions)
- add support for python3.9

fix Radi85#119
fix Radi85#112
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 13, 2020
- also fix some tests that required patching settings.
- reducing time for tests running on travis by running them for lesser environments(still cover all versions)
- add support for python3.9

fix Radi85#119
fix Radi85#112
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 14, 2020
- also fix some tests that required patching settings.
- reducing time for tests running on travis by running them for lesser environments(still cover all versions)
- add support for python3.9

fix Radi85#119
fix Radi85#112
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Dec 27, 2020
Radi85 pushed a commit that referenced this issue Dec 27, 2020
@Radi85 Radi85 closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants