Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch changes to settings for individual tests #132

Closed
abhiabhi94 opened this issue Dec 27, 2020 · 1 comment · Fixed by #134
Closed

Patch changes to settings for individual tests #132

abhiabhi94 opened this issue Dec 27, 2020 · 1 comment · Fixed by #134
Assignees
@abhiabhi94
Labels
codebase
Milestone
2.6.0

Comments

@abhiabhi94
Copy link
Collaborator

Change Type

[ ] Refactor/Enhancement
[x] Testing
[ ] CI/CD
[ ] Other

Proposed Changes

Use the patch function as a decorator or context manager depending upon the use case.
@abhiabhi94 abhiabhi94 self-assigned this Dec 27, 2020
@abhiabhi94 abhiabhi94 added this to the 2.6.0 milestone Dec 27, 2020
@abhiabhi94
Copy link
Collaborator Author

this might also require a bit of refactoring for the tests, and codebase. some existing tests are failing, and it is getting fascinating(annoying) to find-out the exact cause. I need to refactor some existing codebase for better debugging.

abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Jan 3, 2021
@abhiabhi94
test(Radi85#132): Patch settings object for individual tests
a08daa4 
- some refactoring of the original code and tests that may aid in hopefully better debugging.
- fixes Radi85#132
@abhiabhi94 abhiabhi94 mentioned this issue Jan 3, 2021
Merged
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Jan 3, 2021
@abhiabhi94
test(Radi85#132): Patch settings object for individual tests
041e734 
- some refactoring of the original code and tests that may aid in hopefully better debugging.
- fixes Radi85#132
abhiabhi94 added a commit to abhiabhi94/Comment that referenced this issue Jan 3, 2021
@abhiabhi94
test(Radi85#132): Patch settings object for individual tests
d674e7b 
- some refactoring of the original code and tests that may aid in hopefully better debugging.
- fixes Radi85#132
Radi85 pushed a commit that referenced this issue Jan 5, 2021
@abhiabhi94 @Radi85
test(#132): Patch settings object for individual tests
d83902f 
- some refactoring of the original code and tests that may aid in hopefully better debugging.
- fixes #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhiabhi94 abhiabhi94

Labels
codebase
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

test(#132): Patch settings object for individual tests abhiabhi94/Comment
1 participant
@abhiabhi94