Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle access permissions #190

Closed
Radi85 opened this issue Apr 11, 2021 · 0 comments · Fixed by #201
Closed

Handle access permissions #190

Radi85 opened this issue Apr 11, 2021 · 0 comments · Fixed by #201
Assignees
@Radi85
Labels
codebase
Milestone
2.7.0

Comments

@Radi85
Copy link
Owner

Radi85 commented Apr 11, 2021

Change Type

[x] Refactor/Enhancement
[ ] Testing
[ ] CI/CD
[ ] Other

Proposed Changes

comment.mixins

  • Replace the default django response used in the permissions with JsonResponse to be handled properly in the JS functions.
  • Move view mixins to seperate module.
@Radi85 Radi85 self-assigned this Apr 11, 2021
@Radi85 Radi85 mentioned this issue Apr 15, 2021
Merged
Radi85 added a commit that referenced this issue May 3, 2021
@Radi85
feat(#190): handle access permission
81e7744 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
@Radi85 Radi85 mentioned this issue May 3, 2021
Merged
Radi85 added a commit that referenced this issue May 3, 2021
@Radi85
feat(#190): handle access permission
77ff628 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
@Radi85 Radi85 added this to the 2.7.0 milestone May 3, 2021
Radi85 added a commit that referenced this issue May 5, 2021
@Radi85
feat(#190): handle access permission
2210574 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
Radi85 added a commit that referenced this issue May 7, 2021
@Radi85
feat(#190): handle access permission
3091eb1 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
Radi85 added a commit that referenced this issue May 7, 2021
@Radi85
feat(#190): handle access permission
0d9bc00 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
Radi85 added a commit that referenced this issue May 7, 2021
@Radi85
feat(#190): handle access permission
877d4e6 
This will use status code 403 for access deneid in comment mixins and handle it in
JS functions.
Implement blocking views and the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radi85 Radi85

Labels
codebase
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

User blocker Radi85/Comment
1 participant
@Radi85