New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification message via E-Mail #43
Comments
This feature is actually on my list after finishing #33 but with lesser details than you have mentioned, i.e. I didn't think of implementing thread's follower but it seems to be a nice feature alongside with email notifcation. I would like to have this feature implemented including all the points you have mentioned and since you are aware of the whole workflow here, I will be looking forward to your PR :) |
@abhiabhi94 |
What all features are you considering in the first version of this? |
|
As this application becomes more and more complex on the front-end part, I see a reason why That apart, why are you using another model for subscribers? Can't it be a |
That is a nice solution. In fact we work on 2 different views for the same functionality (Django typical view and API view) I was thinking of using the API for our frontend as well and get rid of django typical views. However, this can be for later if we see this is really needed.
I used |
No, no I am not sure I wouldn't would want to go that route. Sometime ago, when I wasn't really familiar with
Seems okay to me as of now. Also. I was thinking of updating the documentation regarding |
Hey @Radi85, one more thing, do you like The fact that our existing test case will still work as before is an added advantage. |
I did not use pytest previously and I don't mind to use it if you think that it can increase our code quality. |
it can help us in writing tests more easily. i am not too sure about the code quality though :) one of the best things that i like about |
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests.
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests.
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests.
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests.
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests. - update docs for subscription
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests. - update docs for subscription
- Add Follower model. - Parent comment and main thread can now be subscribed. - Follow and unfollow functionality is integrated in the UI and the API - Email notification is sent to all thread followers when creating a comment in it. - Tests clean up. - Adjust translation tests. - update docs for subscription
Notification via E-Mail
This is currently requested by my customer and i was wondering if this feature is maybe already in planning within the library itself. If not then I can maybe support. It would be great in that case to get a proposal from you how this should be done correctly
Describe the solution you'd like
What do you about this feature request?
Hope to hear soon from you. CYA
The text was updated successfully, but these errors were encountered: