Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to replace the current convex decomposition implementation with something else #255

Closed
LogicalError opened this issue Jul 15, 2020 · 1 comment
Labels
task A task that needs to be done

Comments

@LogicalError
Copy link
Member

LogicalError commented Jul 15, 2020

We have 2D convex decomposition code (a third party implementation) which is used for extrusion code.
Here you can draw a 2D shape, and it's subdivided into convex shapes since brushes currently need to be convex. Those 2D convex polygons, which the convex decomposition code provide, are then all extruded into 3d brushes.
The CSG algorithm sees these as separate brushes, but in the editor you just see the extruded shape as a single object.

The problem is that this implementation somehow got buggy (the original used to work fine?)
It needs to be fixed (probably easiest to find another bayazit decomposer with the proper license) or replaced with another algorithm, preferably something that can handle self intersections.

@LogicalError LogicalError added the task A task that needs to be done label Jul 15, 2020
@LogicalError
Copy link
Member Author

Fixed in #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task that needs to be done
Projects
None yet
Development

No branches or pull requests

1 participant