Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes icon url #201

Merged
merged 2 commits into from
Jan 4, 2016
Merged

Fixes icon url #201

merged 2 commits into from
Jan 4, 2016

Conversation

mauroservienti
Copy link
Member

@micdenny please review

@micdenny
Copy link
Member

micdenny commented Dec 1, 2015

checked the appveyor artifacts, everything seems ok, merging...

@mauroservienti thank you!

@micdenny
Copy link
Member

micdenny commented Dec 1, 2015

I'm not a good commiter 😄 no merging before version bumping

So I'm asking you @mauroservienti can you please bump the version to a non-breaking number? thanks

@mauroservienti
Copy link
Member Author

done

@mauroservienti
Copy link
Member Author

@micdenny what is missing here to merge? Seems OK. I also rebased from develop to be aligned and is still on track

@micdenny
Copy link
Member

micdenny commented Jan 4, 2016

probably didn't saw the email (actually sometimes I just cleanup my email folders) 😄

merging right now...

micdenny added a commit that referenced this pull request Jan 4, 2016
@micdenny micdenny merged commit cc813f3 into develop Jan 4, 2016
@micdenny
Copy link
Member

micdenny commented Jan 4, 2016

done, thsnk!

@mauroservienti mauroservienti deleted the icon-url-fix branch January 5, 2016 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants