Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Bullseye and SimpleExec #255

Merged
merged 3 commits into from
Sep 21, 2018
Merged

switch to Bullseye and SimpleExec #255

merged 3 commits into from
Sep 21, 2018

Conversation

adamralph
Copy link
Contributor

  • Bullseye replaces simple-targets-csx (it's a regular binary package instead of scripts, so can optionally be used in a regular .NET project).
  • SimpleExec wraps up command invocation, so removes the need to include local helpers

@adamralph adamralph requested a review from a team as a code owner June 24, 2018 21:40
@adamralph
Copy link
Contributor Author

I think the build is failing for an unrelated reason.

@mauroservienti
Copy link
Member

thanks @adamralph ! I'll have a look at the build server error to understand what's going on.

@adamralph
Copy link
Contributor Author

FYI I amended the commits to use Bullseye.1.0.0-rc.4 and SimpleExec.2.2.0 (using netstandard2.0).

@adamralph adamralph mentioned this pull request Jun 26, 2018
7 tasks
@mauroservienti mauroservienti self-assigned this Sep 21, 2018
@mauroservienti mauroservienti merged commit f2f4773 into RadicalFx:develop Sep 21, 2018
@adamralph adamralph deleted the build-packages branch September 21, 2018 14:53
@adamralph
Copy link
Contributor Author

@mauroservienti @nazarenomanco the last commit broke the script. When the versions of packages are updated, the corresponding paths in the scripts need to be changed:

I wondered why the CI build didn't fail, but that's because you are not using the build script in appveyor.yml. I recommend switching appveyor.yml to use the build script, so that the same process is used both locally and in CI, and your CI will guarantee that the build script works.

Also, you may want to consider switching to a regular C# project instead of a script. That will remove the need to use Microsoft.Net.Compilers and you can upgrade to newer versions of Bullseye and SimpleExec by editing the csproj only. And if you can switch to using dotnet instead of msbuild then you can remove the need to use vswhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants