ARM support, ommiting episode names and adding a "0" prefix to episode and season numbers #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: S1E1 My mom is a milf?! To: S1E1
Formatting change: from S1E1 to S1 - E1 When leading 0 is enabled: S01 - E01
|
The new formatting change from |
Make the behavior configurable, so: from S1E1 to S1 - E1
|
As requested, both features added |
Radiicall
requested changes
Apr 14, 2024
i forgor about release.yml, sowwy
|
I hope I fixed everything you requested, sorry if i missed something its almost 4 am here xd |
Haha same, weekends am i right |
Radiicall
reviewed
Apr 14, 2024
|
would the way i did it be appropriate as well? I am not a big ARM guy so i dont know if armv7 and aarch64 are the only possible variations |
covering all the bases, not sure how many cpu codenames does ARM have
Changed checking code and check arm64 before arm
Radiicall
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As visible from the title, this pull request adds the following:
I have tried the generated binary on raspberry pi 2b (ARMv7), and im fully hoping AARCH64 has backwards compatibility for 32-bit so we can call it full ARM support on linux xd. Stripping is done by emulating alpine linux to the armv7 arch because when i tried to strip it on a x64 bit system it failed.
Now i am not quite sure if you will like this change, but i think having it in a format S1 - E1 is better than S1E1, but of course this is purely subjective
I find it quite clunky when the whole name is there, so i added an option to just have S1 - E1 instead of S1 - E1 Episode name
Last but not least, i added the option to append 0 to the season or episode number if its less than 9 (hopefully xd) so S01 - E01
If you have any questions please ask! I really like this project and i just dont understand why this hasnt been done natively by jellyfin yet