Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 plugin versions to match CI #1364

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

bhazelton
Copy link
Member

Description

The pre-commit CI is great at keeping the top-level packages up to date and with clearly specified versions. Unfortunately, the flake-8 plugin versions are not controlled so well. Recently, one of those plugins released a new version, which was picked up by the CI because it builds a fresh environment. This updates the versions of all of the flake8 plugins so we will get the same versions on our machines as are being used in the CI.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1364 (abd6408) into main (c643bfd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1364   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          36       36           
  Lines       20230    20230           
=======================================
  Hits        20214    20214           
  Misses         16       16           
Files Coverage Δ
pyuvdata/uvdata/mwa_corr_fits.py 100.00% <ø> (ø)
pyuvdata/uvdata/uvdata.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c643bfd...abd6408. Read the comment docs.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine. Do we then need to do this manually every now and then?

@bhazelton bhazelton merged commit 6a877ff into main Dec 15, 2023
55 checks passed
@bhazelton bhazelton deleted the precommit_cleanup branch December 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants