-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phasing memo 2.0 #1442
Phasing memo 2.0 #1442
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prep_v3.0 #1442 +/- ##
=============================================
- Coverage 99.93% 99.93% -0.01%
=============================================
Files 41 40 -1
Lines 21138 21103 -35
=============================================
- Hits 21124 21089 -35
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Why is the calfits memo pdf updated in this PR? |
@bhazelton -- I edited the calfits.tex file in #1437 but forgot to recompile. At issue I believe was the update for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! Lots of little comments but generally I really like your updates, especially the primer on celestial coordinate systems -- super useful.
Thanks @bhazelton! All little comments should now be addressed (along with one final check for misspellings which I apparently forgot to do on the last run). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple more minor things but I think we're close!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!!
Updates the phasing memo.
Description
Updates the phasing memo to document the "new" phasing framework within pyuvdata (primarily for
UVData
objects).Motivation and Context
I was asked for documentation on phasing, and 3 years later I've finally finished it!
Types of changes
Checklist:
Documentation change checklist: