Radius Custom Templates #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Now we can use our Radius custom templates for a scaffolded controller and action views. A project using this will still need to have `slim-rails` in it's own Gemfile since we are not monkey-patching any generators. However, because of that, we need to work around how the generators work. By default, rails will look for a template, and generate that first one it finds. Since our custom templates are in a gem, rails will find a template (default) in the project and spit it out. We want to check `radius-rails` first for any templates before going back to the defaults. Those changes are in `lib/radius-rails.rb`.
cupakromer
reviewed
Oct 18, 2018
cupakromer
reviewed
Oct 22, 2018
| .panel-heading | ||
| | My <%= plural_table_name.titleize %> | ||
|
|
||
| table.table.table-hover.table-generic |
There was a problem hiding this comment.
I think we need to move the .table-generic and any related styling over too.
csexton
approved these changes
Oct 23, 2018
|
@cupakromer Okay I think this is ready to merge and has all the basics for controller and view files. We are using |
cupakromer
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I jumped the gun a bit on this PR - still WIP
Now we can use our Radius custom templates for a scaffolded controller and action views. A project using this will still need to have
slim-railsin it's ownGemfilesince we are not monkey-patching any generators. However, because of that, we need to tweak and work around the generators behavior.By default, rails will look for a template, and generate that first one it finds. Since our custom templates are in a gem, rails will find a template (default) in the project and spit it out. We want to check
radius-railsfirst for any templates before going back to the defaults. Those changes are inlib/radius-rails.rb. I found that answer here.I remember I had an issue with a datetimepicker that wasn't resolved in an early version of
2.0.0so I bumped the version.