Upgrade rubocop #27
Merged
Upgrade rubocop #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron Hill <armahillo@gmail.com> Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: Chris Hoffman <choffman@radiusnetworks.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Aaron Hill <armahillo@gmail.com> Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: Chris Hoffman <choffman@radiusnetworks.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Aaron Hill <armahillo@gmail.com> Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: Chris Hoffman <choffman@radiusnetworks.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
benreyn
requested review from
cupakromer,
jnebeker,
alexstone,
armahillo,
jcavena,
lankyfrenchman,
sam-kim and
yarmiganosca
|
According to this comment the error we're seeing should be resolved in version 0.89: |
Co-authored-by: JC Avena <jcavena@gmail.com> Co-authored-by: Chris Hoffman <choffman@radiusnetworks.com> Co-authored-by: Sam Kim <sam@radiusnetworks.com>
Co-authored-by: JC Avena <jcavena@gmail.com> Co-authored-by: Chris Hoffman <choffman@radiusnetworks.com> Co-authored-by: Sam Kim <sam@radiusnetworks.com>
This benchmarks the advise for the [Style/HashLikeCase][1] check. Usage of `case` appears to be more performant than a hash. However, both are highly performant, so any difference is likely negligible compared to other performance issues. Thus our decision for preference should be based on readability and comprehension. [1]: https://docs.rubocop.org/rubocop/1.21/cops_style.html#styleredundantfileextensioninrequire
We are now on the Rubocop version which implements the setting as we wished it to be configured.
cupakromer
force-pushed
the
upgrade-rubocop
branch
from
d969ce1
to
33c3296
Compare
cupakromer
approved these changes
Sep 24, 2021
benreyn
added a commit
that referenced
this pull request
Sep 30, 2021
[Full Changelog](v0.8.0...v0.9.0) Enhancements ------------ - Upgrade to Rubocop 0.89.x (Aaron Hill, Aaron Kromer, Ben Reynolds, Chris Hoffman, James Nebeker, JC Avena, Sam Kim #27) - Upgrade to Rubocop Rails 2.6.x (Aaron Hill, Aaron Kromer, Ben Reynolds, Chris Hoffman, James Nebeker, JC Avena, Sam Kim #27) - Adjust common Rubocop configuration (Aaron Hill, Aaron Kromer, Ben Reynolds, Chris Hoffman, James Nebeker, JC Avena, Sam Kim #27) - Configure multiple metrics to use the `CountAsOne` option for array, hash and heredocs - Disable `Style/SlicingWithRange` as we do not care about the style - Includes new `shared_example` / `shared_context` inclusion aliases `has_behavior` and `it_has_behavior` for behavior driven development language (Aaron Kromer, Ben Reynolds #28) Bug Fixes --------- None Breaking Changes ---------------- - Change the default behavior from `:warn` to `:raise` for RSpec expectations behavior `on_potential_false_positives` (Aaron Kromer, Ben Reynolds #28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this up as a draft. CI ended up failing on this version for some indeterminate reason. Spent a cycle on it myself and then asked @cupakromer for a second set of eyes. We couldn't figure it out quickly, so we are punting the fix to next week. 馃憻 馃張CI Passing! This chunk of updates is ready for everyone to review!