Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typo error BarLifeDrawPorition should be BarLifeDrawPosition #515

Closed
pertusatti22 opened this issue May 17, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@pertusatti22
Copy link

What happened?

Has been a while I want to develop some games, and bonfire helping me a lot with!
While watching the series of Tower Defense, I noticed this typo error and thinking it a good way to start my contribution.

I clone the repo and try to figure it out and send a PR, and at your disposal to start contributing.
Thanks again for bonfire.

Regards!

Steps to reproduce?

1. Create some attackable
2. setup LifeBar
3. barLifeDrawPosition

setupLifeBar(barLifeDrawPosition: BarLifeDrawPorition.bottom);

What did you expect to happen?

setupLifeBar(barLifeDrawPosition: BarLifeDrawPosition.bottom);

Bonfire version

3.8.7

Relevant log output

No response

@pertusatti22 pertusatti22 added the bug Something isn't working label May 17, 2024
@pertusatti22
Copy link
Author

The fix was done, just don't have permission,
Waiting for contact
__
Commit message
fix: correct typo in BarLifeDrawPorition to BarLifeDrawPosition (#515)

How

  • Renamed BarLifeDrawPorition to BarLifeDrawPosition in the barlife_component.dart.
  • Check for usages and reference errors in use_barlife.dart

Can't create a new pull request: Push failed: remote: Permission to RafaelBarbosatec/bonfire.git denied to pertusatti22. unable to access 'https://github.com/RafaelBarbosatec/bonfire.git/': The requested URL returned error: 403

@RafaelBarbosatec
Copy link
Owner

Thanks so much for this reporting!
Available in the version 3.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants