Improve css styling #31
Conversation
|
@artisticat1 OMG nice work! I will test it and merge as soon as posible |
RafaelGB
added this to 👩💻👨💻 In progress
in Obsidian database plugin Roadmap
via automation
| @@ -30,12 +30,7 @@ export default function GlobalFilter(globalFilterProps: GlobalFilterProps) { | |||
| onChange(e.target.value); | |||
| }} | |||
| placeholder={`${count} records...`} | |||
| style={{ | |||
There was a problem hiding this comment.
About this erase of style. It is necessary to lose the background property?
There was a problem hiding this comment.
I removed all the styling (including the background property) since it'd be handled by the styling of input[type=search] in the user's theme.
| @@ -1,312 +1,326 @@ | |||
| @import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap"); | |||
There was a problem hiding this comment.
I can't see the real differences well. All the file looks modified. I thinks its my fault because I don't have the prettier enabled with css.
I added few things with 0.2.1 release. padding but I will merge and add again =) thanks!
There was a problem hiding this comment.
Oh, oops! VScode didn't show me any of these changes when I was committing.
|
Your contribution was tested and will be added with 0.3.0 I am working with PR feedback of the official release. Your add button align fixed one of the dots =) |
Awesome! Glad I could help :D Thanks for the plugin! |
This PR improves some of the css styling. It fixes misaligned icons, the gap after the headings causing misaligned columns, invisible text, etc. It also changes the popovers to use the
menucss class in obsidian, so that they get styled by themes.Here's what the plugin looks like before:
and after:
It also works well with all other themes I tested:
I'm not familiar with react, so let me know if I made any bad choices!