feat(date-format): added more tests cases #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
reviewed
Jan 7, 2023
H4ad
force-pushed
the
feat/more-benchmark-for-date-format
branch
from
bef059e
to
11290b0
Compare
RafaelGSS
reviewed
Jan 7, 2023
H4ad
force-pushed
the
feat/more-benchmark-for-date-format
branch
from
11290b0
to
04f6a85
Compare
RafaelGSS
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some performance improvements to nestjs/nest#10823, and one of the improvements I found was that the
toLocaleDateStringfunction with locale options is much slower thanIntl.DateTimeFormatpassing the same arguments.So I added the same options I see in NestJS with the comparison to
Intl.DateTimeFormatcreating new instances and reusing the same instance.I don't know if I'm comparing apple to oranges but I think that worth to know the difference.
Also, for some reason, in that Pull Request I found a difference performance from 1ms to 13ms switching NodeJS version, I tried to isolate the issue but I didn't find any reason that could indicate that NodeJS was the problem, so I think that running inside this tests could bring more light to that problem.