Improvement of parse function

[PatrikHlobil]

Hi Rafal,

I have to say that your visum_to_pandas script is great. I worked a bit on the most recent version and made the following changes/improvement for the "parse" function:

• use os.path.join for the combination of paths
• use "string".split(9 to get rid of newline and space characters
• auto-detect COL_SEPARATOR
• do not export index of DataFrame
• add parameters (export_path, export) to the parse function:

:param export_path (optional): Path to folder, where to save the CSV files.
If not specified, the CSV files are save in
folder of the net files.
:param export (optional): List of network objects that should be exported. If
not specified, all network objects will be exported.

If you like, you can just include my changes in your code. The file was uploaded with the name "ptv_visum_to_pandas_2.py".

Best regards,

Patrik

[RafalKucharskiPK]

Hi Patrik,

thanks for commitment. Your imporovements are nice, I appreciate.
Please try to create a pull request so that we can merge.

• I'd like to still modify some of the code, e.g. we do not need have twice calls to pd.DataFrame() after if export != None:
• I'd like to check if your 'COL_SEPARATOR' identification works for OSX also (since I use it a lot).
• It'd be nice to have a list of tables available to export prepared in code, so that user can refer to it.
• the paths and params of the script, they shall be ultimately unified into some .json config or sth similar - so that maybe you idea of passing path as param maybe not needed.

Thanks again
Rafał

[PatrikHlobil]

Hi Rafal,

I created a branch and a pull request (this is my first contribution on GitHub, so still learning how all that works : D ).

How exactly do you think users should use the script? I don't understand why you want to use a .json config in combination with the script? I thought that it should serve as a module, from which you can load the functions when needed. In this case, one has to specify the parameters that I introduced. What are your thought on this?

Best,
Patrik

[RafalKucharskiPK]

​Hi Patrik, the merge went well - i.e. your improvements are now on the trunk merged with mine. Please see the current readme.md to see my idea of the script logic. 2018-04-26 10:50 GMT+02:00 patrikhlobil <notifications@github.com> [Non-original Sender] / < bounces+848413-80cf-rkucharski=pk.edu.pl@sgmail.github.com>:

…

Hi Rafal, I created a branch and a pull request (this is my first contribution on GitHub, so still learning how all that works : D ). How exactly do you think users should use the script? I don't understand why you want to use a .json config in combination with the script? I thought that it should serve as a module, from which you can load the functions when needed. In this case, one has to specify the parameters that I introduced. What are your thought on this? Best, Patrik — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATmmu5_6UbyyTdFIM1pifX9aO-_FLEpyks5tsYo0gaJpZM4Tkru8> .

-- Pozdrawiam/Best Regards Rafał Kucharski Katedra Systemów Transportowych Politechnika Krakowska m: rkucharski@pk.edu.pl