Develop (#168)

* updated codacy scanning workflow with new tests values

* updated codacy setting for branch scanning

* Updated readme, added codacy badge

.codacy.yml

@@ -1,7 +1,5 @@
 ---
 engines:
-  hadolint:
-  markdownlint:
   phpcs:
     php_version: 8.2
   phpmd:

Makefile

@@ -179,8 +179,8 @@ github_actions_static_analysis:
 phpcs_gh:
 	vendor/bin/phpcs --standard=config/analysis/phpcs.xml --report=checkstyle | cs2pr
 
-.PHONY: lint test_unit
-sonar_static_analysis:
+.PHONY: sonar_static_analysis
+sonar_static_analysis: lint tests
 	-vendor/bin/psalm --report=./var/reports/psalm.sonarqube.json --config=config/analysis/psalm.xml
 	-vendor/bin/phpstan analyse --configuration=config/analysis/phpstan.neon --error-format=json > ./var/reports/phpstan.sonarqube.report.json || true
 	sonar-scanner -Dsonar.host.url=${SONAR_HOST} -Dsonar.token=${SONAR_TOKEN}

README.md

@@ -21,7 +21,6 @@ External services
 
 Codacy:
 [![Codacy Badge](https://app.codacy.com/project/badge/Grade/7621ab51388d4f4aa5b0528030eb5f57)](https://app.codacy.com/gh/RafalSalwa/interview-client-php/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_grade)
-[![Codacy Badge](https://app.codacy.com/project/badge/Coverage/7621ab51388d4f4aa5b0528030eb5f57)](https://app.codacy.com/gh/RafalSalwa/interview-client-php/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_coverage)
 
 SonarQube: [![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=RafalSalwa_Shop&metric=ncloc)](https://sonarcloud.io/summary/new_code?id=RafalSalwa_Shop)
 [![Duplicated Lines (%)](https://sonarcloud.io/api/project_badges/measure?project=RafalSalwa_Shop&metric=duplicated_lines_density)](https://sonarcloud.io/summary/new_code?id=RafalSalwa_Shop)

sonar-project.properties

@@ -1,6 +1,6 @@
 # must be unique in a given SonarQube instance
-sonar.projectKey=Shopping-App
-
+sonar.projectKey=RafalSalwa_Shop
+sonar.organization=rafalsalwa
 # --- optional properties ---
 sonar.projectName=Shopping-App
 sonar.language=php