Support MS Windows #463
Merged
Support MS Windows #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check at meson level if "gdbus-codegen" is available and otherwise exit cleanly, possibly building without MPRIS feature instead of failing.
We do not install headers from gst-plugin, but still need to export symbols to compile modules that use plugin provided shared libraries.
We cannot run app without schemas, thus we need to compile and install them on any OS
We need to ensure types that are not part of public API, otherwise GtkBuilder will fail to use them (https://gitlab.gnome.org/GNOME/gtk/-/blob/e81aad25a19aa8e1ec9b5192ec0a71985a1a434b/gtk/glade/README.glade#L15).
We need to ensure types that are not part of public API, otherwise GtkBuilder will fail to use them (https://gitlab.gnome.org/GNOME/gtk/-/blob/e81aad25a19aa8e1ec9b5192ec0a71985a1a434b/gtk/glade/README.glade#L15).
When compiling without MPRIS feature "instance_count" is left unused, so skip it with preprocessor in order to avoid warning.
Rafostar
force-pushed
the
ms-win
branch
15 times, most recently
from
ce2b999
to
eafbbae
Compare
Rafostar
force-pushed
the
ms-win
branch
3 times, most recently
from
eaa274a
to
19b8920
Compare
Rafostar
force-pushed
the
ms-win
branch
5 times, most recently
from
0dfee1b
to
b07fa59
Compare
Windows does not support mime-types file filters, so use file extensions instead
They are unsupported. We use file extensions instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support building and running both Clapper libraries and application itself on MS Windows. Thankfully, newly rewritten code seems to be fine as-is and the only needed changes are supporting DLL visibility and some meson buildsystem tweaks.
Fixes #103