Fix: prevent meaningless scheduling iterations of simpleschedule with penalty. #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR - Too simple simplescheduler
The current simplescheduler schedules the kernel as fast as the CPU runs. When the stream from a source kernel is generated at very high frequency, the current simplescheduler would be fine. However, when the upstream kernel runs at a lower frequency, scheduling kernels dominates the CPU core usage while the scheduled kernel's run() is not executed.
The demonstration of this bug is done by the two cases of poc.cpp. The demonstration codes of modified poc.cpp are here.
While these two cases did almost the same things, the CPU usages were very different and it caused the different energy consumptions also.
To prevent this inefficiency, I checked whether the scheduled kernel run() is really executed, and if not, penalized the next scheduling with 5 ms of sleeping. It is quite hacky and simple, but I think it would be fine with the "simple" scheduler.
For further schedulers, a more fancy backoff mechanism can be applied such as exponential backoff which was adopted by the network community in the past.
With my small modification, I re-tested the above cases, and th results are followings:
Fixes #163
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Details
I tested my commit on Ubuntu 20.04 and 22.04.
Please list test cases created to ensure your feature or addition
works.
Checklist: