Reimplement ADC HAL #163
Merged
Reimplement ADC HAL #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
Reimplement the ADC HAL with a design similar to the other new implementations. This means we have a common `Adc<...>` type defined in avr-hal-generic which internally uses a concrete ADC peripheral which implements the `AdcOps` trait. Additionally, an `AdcChannel` trait is used to mark channels which can be used with a certain ADC.
Add necessary plumbing to use IO pins as ADC channels. This consists of: - The `into_analog_input()` method to "convert" an IO pin into an ADC channel. Under the hood, this sets the "DIDR" (Digital Input Disable) bit. - The `analog_read()` method for ADC pins. This is sugar for calling `adc.read_blocking(&pin)`, to provide an API that's close the the one commonly used in the Arduino world.
Implement ADC support for all currently supported ATmega microcontrollers.
Reexport the `adc` module from the HAL crate to make the ADC easily usable.
Add a type that can represent any channel for e.g. storing a list of channels in an array. Ref: #33
Add ADC examples for all boards to demonstrate how to read from the analog pins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of the ADC HAL and support for all MCUs in
atmega-hal. Also addressed issue #33 already.Notably, I dropped the implementation of the embedded-hal ADC traits for now. As discussed in #33 they are currently unfit for the purpose and instead of bending over backwards, I dropped them with the intention to re-add an implementation once embedded-hal hits 1.0.
Downstream code will look like this now: