Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MAX7321 #10

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Add support for MAX7321 #10

merged 1 commit into from
Aug 13, 2023

Conversation

zandemax
Copy link
Contributor

This PR adds support for the MAX7321 I2C Port Expander.

This chip is very similar to the already implemented PCF8574.

Rahix
Rahix requested changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Code looks great, CI is complaining about formatting though. The change it wants looks stupid, not sure what rustfmt is doing there, but can you apply the reformat regardless please?

@zandemax
Copy link
Contributor Author

Ah yes of course, I must have missed a last cargo fmt before pushing. Should be fixed now.

@Rahix Rahix self-requested a review August 13, 2023 17:07
Rahix
Rahix approved these changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rahix Rahix merged commit 90ae28f into Rahix:main Aug 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zandemax @Rahix