-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v6.7 - Mapping updates for all dungeons #1797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now going to write tests
…ents. Not committed the combat logs used for testing - will do that in a separate package when I pull it apart from Keystone.guru repository
I can now take a combat log and condense it down to a list of events of enemies' first sightings
…ents are properly shown at the right location (and I can reference NPCs near those locations)
…r unknown suffixes, prefixes
…combat logs have M+ dungeons in them before I keep them around.
…upported instead of just in an artisan command
This fixes an issue when someone is not on /1 page and has their route name resolve to an integer. It'll then think the floor index is the route title and all kinds of things break.
…ions to the actual runs being done. Affixes are also assigned properly for these routes
…s and zip them up again
…dated MDT version
…log. But only if the found enemy is at least 50 yards away. Also enemies that are 100 yards away from the source we just skip it - something must be wrong.
…th percentage (and then despawning) instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping changes:
Bugfixes: