Ordering issue with has_many and "nulls last"

[jgadbois]

Using Rails 4 and Postgres. Invalid sql is generated with a custom has_many order clause when accessing .last

#models/profile.rb
class Profile < ActiveRecord::Base
  has_many :offers, -> { where(:deleted_at=>nil).order('featured ASC nulls last, id DESC') }
end

# models/offer.rb
class Offer < ActiveRecord::Base
  belongs_to :profile
end

## rails c

# works
>> AuthorProfile.first.offers.first 

# SQL error
>> AuthorProfile.first.offers.last

ActiveRecord::StatementInvalid: PG::Error: ERROR:  syntax error at or near "DESC"
LINE 1: ...ted_at" IS NULL  ORDER BY featured ASC nulls last DESC, id A...
                                                             ^
: SELECT  "offers".* FROM "offers"  WHERE "offers"."profile_id" = $1 AND "offers"."deleted_at" IS NULL  ORDER BY featured ASC nulls last DESC, id ASC LIMIT 1

[pftg]

Confirm for 4.0.0, 3.2.13 and for master:

unless File.exists?('Gemfile')
  File.write('Gemfile', <<-GEMFILE)
    source 'https://rubygems.org'
    #gem 'rails', path: '../rails'
    #gem 'rails', '= 3.2.13'
    gem 'rails', '= 4.0.0'
    gem 'sqlite3'
  GEMFILE

  system 'bundle'
end

require 'bundler'
Bundler.setup(:default)

require 'active_record'
require 'minitest/autorun'
require 'logger'

# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)


ActiveRecord::Schema.define do
  create_table :items do |t|
    t.string 'type'
  end
end

class Item < ActiveRecord::Base
  default_scope { order 'type ASC nulls last' }
end

class BugTest < MiniTest::Unit::TestCase
  def test_association_stuff
    assert_includes Item.last.to_sql, 'ORDER BY type DESC nulls last LIMIT 1'
  end
end

Investigating in resolving the issue.

[ghiculescu]

Hi, any updates on this one?

[pftg]

There is PR for this issue: #7423

[rafaelfranca]

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-1-stable, 4-0-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

[laurocaetano]

Just removed the stale tag since it still an issue and it has a PR: #7423

[sgrif]

We'v rejected the PRs for this issue, so I'm closing this as wontfix.