<route>_url helpers should know if they should be using https or http

[joevandyk]

If I specify in my routes that a given URL should be using https, then using the _url route helper should output a https url.

Example:

scope :constraints => { :protocol => "https" } do
  match '/login' => 'controller#action', :as => 'login'
end

match '/' => 'welcome#index', :as => 'index'

login_url should output https://domain.com/login , even if I'm on a http page.

index_url should output http://domain.com/, even if I'm on a https page.

See http://stackoverflow.com/questions/3993651/rails-3-ssl-routing-redirects-from-https-to-http and http://stackoverflow.com/questions/6699881/getting-rails-url-helpers-to-automatically-output-https-urls for a discussion of this issue.

[sarahhodne]

I agree with you on the login_url part, but I don't think you should change off of HTTPS automatically, as you propose for index_url. Also, one of the links you posted has a solution for how to make this work.

[joevandyk]

I saw the solution in the stackoverflow ticket, but it involved overriding url_for in multiple places, which seems hacky.

Maybe if you constrain index_url to http then it would switch back to http? If there's no protocol constraints, then it doesn't touch it?

[sarahhodne]

From what I can see, this is what the Stack Overflow ticket is suggesting:

# routes.rb
scope :protocol => 'https://', :constraints => { :protocol => 'https://' } do
  resources :sessions
end

resources :gizmos

So no url_for overriding (unless you want https -> http which I said I thought was a bad idea, I'll expand on that thought if you want me to).

[joevandyk]

I can't seem to get those routes to work though, using the above routes file, when I use new_session_url in a view, I get this error:

No route matches {:action=>"new", :controller=>"sessions"}

It (of course) works when I remove the scope from around the resources :sessions.

[isaacsanders]

@joevandyk any news in this? @tenderlove @josevalim

[joevandyk]

I think it's still a problem. Would love to have it fixed.

[isaacsanders]

Do you have time to work on a patch?