Skip to content

Commit

Permalink
Don't pass RUBYOPT to bundle install
Browse files Browse the repository at this point in the history
The mysql2 gem has lots of troubles building via extconf.rb with frozen
strings.
  • Loading branch information
mostlyobvious committed Jan 23, 2024
1 parent 253695b commit 6587670
Show file tree
Hide file tree
Showing 52 changed files with 145 additions and 97 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/aggregate_root_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: aggregate_root
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/aggregate_root_mutate.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: aggregate_root
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -58,4 +57,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/aggregate_root_test.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: aggregate_root
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand Down Expand Up @@ -66,4 +65,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/dres_client_test.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/dres_client
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -56,4 +55,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/dres_rails_test.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/dres_rails
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
DATABASE_URL: "${{ matrix.database_url }}"
Expand Down Expand Up @@ -95,4 +94,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/minitest-ruby_event_store_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/minitest-ruby_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/minitest-ruby_event_store_mutate.yml
Expand Up @@ -27,7 +27,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/minitest-ruby_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -48,4 +47,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/minitest-ruby_event_store_test.yml
Expand Up @@ -27,7 +27,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/minitest-ruby_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -54,4 +53,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/rails_event_store_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: rails_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/rails_event_store_mutate.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: rails_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -58,4 +57,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/rails_event_store_test.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: rails_event_store
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand Down Expand Up @@ -70,4 +69,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-active_record_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-active_record
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-active_record_mutate.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-active_record
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -58,4 +57,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-active_record_test.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-active_record
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
DATABASE_URL: "${{ matrix.database_url }}"
Expand Down Expand Up @@ -139,4 +138,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 4 additions & 1 deletion .github/workflows/ruby_event_store-browser_assets.yml
Expand Up @@ -11,7 +11,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-browser
RUBYOPT: "--enable-frozen-string-literal"
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -27,8 +26,12 @@ jobs:
key: elm-${{ hashFiles(format('{0}/elm/elm.json', env.WORKING_DIRECTORY)) }}
- run: make install-npm
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
- run: make build-npm
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
- uses: actions/upload-artifact@v3
with:
name: ruby_event_store_browser.js
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-browser_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-browser
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-browser_mutate.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-browser
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -58,4 +57,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-browser_test.yml
Expand Up @@ -37,7 +37,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: ruby_event_store-browser
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand Down Expand Up @@ -77,4 +76,6 @@ jobs:
path: "~/.elm"
key: elm-${{ hashFiles(format('{0}/elm/elm.json', env.WORKING_DIRECTORY)) }}
- run: make install-npm test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-flipper_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/ruby_event_store-flipper
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-flipper_mutate.yml
Expand Up @@ -27,7 +27,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/ruby_event_store-flipper
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -48,4 +47,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate-changes
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-flipper_test.yml
Expand Up @@ -27,7 +27,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/ruby_event_store-flipper
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand Down Expand Up @@ -58,4 +57,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make test
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"
5 changes: 3 additions & 2 deletions .github/workflows/ruby_event_store-newrelic_coverage.yml
Expand Up @@ -29,7 +29,6 @@ jobs:
timeout-minutes: 120
env:
WORKING_DIRECTORY: contrib/ruby_event_store-newrelic
RUBYOPT: "--enable-frozen-string-literal"
RUBY_VERSION: "${{ matrix.ruby_version }}"
BUNDLE_GEMFILE: "${{ matrix.bundle_gemfile }}"
strategy:
Expand All @@ -50,4 +49,6 @@ jobs:
bundler-cache: true
working-directory: "${{ env.WORKING_DIRECTORY }}"
- run: make mutate
working-directory: "${{ env.WORKING_DIRECTORY }}"
working-directory: "${{ env.WORKING_DIRECTORY }}"
env:
RUBYOPT: "--enable-frozen-string-literal"

0 comments on commit 6587670

Please sign in to comment.