Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 6.0.0 support broke (worked on 6.0.0.rc1) #669

Closed
mostlyobvious opened this issue Sep 17, 2019 · 0 comments
Closed

Rails 6.0.0 support broke (worked on 6.0.0.rc1) #669

mostlyobvious opened this issue Sep 17, 2019 · 0 comments
Assignees
@mostlyobvious
Labels
bug

Comments

@mostlyobvious
Copy link
Member

https://circleci.com/gh/RailsEventStore/rails_event_store/29869

Keywords:

  • trigger_transactional_callbacks
  • RailsEventStore::AfterCommitAsyncDispatcher::AsyncRecord

Possibly related:
https://review.discourse.org/t/dev-upgrading-discourse-to-rails-6-pr-8083/5578
mostlyobvious added a commit that referenced this issue Sep 18, 2019
@mostlyobvious
Add required AsyncRecord method since AR 6.0
7fa993e 
Return value of this method has no effect on AsyncRecord#committed! and
AsyncRecord#rolledback!

[#669]
@mostlyobvious mostlyobvious self-assigned this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostlyobvious mostlyobvious

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mostlyobvious