-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ActiveJob adapters with pre-deserialized events and NULL serializer #1335
Closed
milgner
wants to merge
1
commit into
RailsEventStore:master
from
re-gmbh:fix/async-handler-interface
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,21 +2,32 @@ | |
|
||
module RailsEventStore | ||
module AsyncHandler | ||
def self.with_defaults | ||
with | ||
end | ||
class << self | ||
def with_defaults | ||
with | ||
end | ||
|
||
def self.with(event_store: Rails.configuration.event_store, event_store_locator: nil, serializer: RubyEventStore::Serializers::YAML) | ||
Module.new do | ||
define_method :perform do |payload| | ||
event_store = event_store_locator.call if event_store_locator | ||
super(event_store.deserialize(serializer: serializer, **payload.symbolize_keys)) | ||
def with(event_store: Rails.configuration.event_store, event_store_locator: nil, serializer: RubyEventStore::Serializers::YAML) | ||
Module.new do | ||
define_method :perform do |payload| | ||
event_store = event_store_locator.call if event_store_locator | ||
record = AsyncHandler.event_from_payload(payload, event_store, serializer) | ||
super(record) | ||
end | ||
end | ||
end | ||
end | ||
|
||
def self.prepended(host_class) | ||
host_class.prepend with_defaults | ||
def prepended(host_class) | ||
host_class.prepend with_defaults | ||
end | ||
|
||
# @return [Event] an event as deserialized from the payload | ||
def event_from_payload(payload, event_store, serializer) | ||
return payload if payload.kind_of?(RailsEventStore::Event) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't require Event objects in RES to be of this kind. It's likely they are but we accept anything that has the same interface as |
||
|
||
payload_hash = payload.to_h.symbolize_keys | ||
event_store.deserialize(serializer: serializer, **payload_hash) | ||
end | ||
end | ||
end | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this was necessary change. Changing to
class << self
overself.
made it harder to notice what really changed. A separate commit with only this change would be helpful in the future.