AggregateRoot's repository instrumentation #591
Conversation
Instruments `load` & `store` methods. Tracks aggregate class, stream and for storing also current aggregate version & number of events stored.
| instrumentation.instrument("store.repository.aggregate_root", | ||
| aggregate_class: aggregate.class, | ||
| aggregate_version: aggregate.version, | ||
| stored_events: aggregate.unpublished_events.size, |
There was a problem hiding this comment.
Perhaps we should pass just aggregate.unpublished_events here. That would be in symmetry with append_to_stream.repository.rails_event_store.
| aggregate_class: aggregate.class, | ||
| aggregate_version: aggregate.version, | ||
| stored_events: aggregate.unpublished_events.size, | ||
| stream_name: stream_name) do |
There was a problem hiding this comment.
s/stream_name/stream, again following append_to_stream.repository.rails_event_store
| def store(aggregate, stream_name) | ||
| instrumentation.instrument("store.repository.aggregate_root", | ||
| aggregate_class: aggregate.class, | ||
| aggregate_version: aggregate.version, |
There was a problem hiding this comment.
s/aggregate_version/version/
|
|
||
| def store(aggregate, stream_name) | ||
| instrumentation.instrument("store.repository.aggregate_root", | ||
| aggregate_class: aggregate.class, |
There was a problem hiding this comment.
I think passing the instance, labeled as aggregate would be fine (thus s/aggregate_class/aggregate/)
There was a problem hiding this comment.
Instrumentation is useful in logging context, being able to track particular instance is helping.
|
|
||
| describe "#load" do | ||
| specify "wraps around original implementation" do | ||
| some_repository = spy |
There was a problem hiding this comment.
Is there a way for spy to check if it still follows an API that is mocked? I'm always wary of such tests. I briefly remember https://github.com/psyho/bogus implementing this check.
There was a problem hiding this comment.
|
|
||
| expect(notification_calls).to eq([{ | ||
| aggregate_class: Order, | ||
| aggregate_version: -1, |
There was a problem hiding this comment.
Interesting question, are we more interested in version before or after storing events? Also what happens in context of instrumentation if we cannot store events?
There was a problem hiding this comment.
Usually repository gets a new instance of aggregate, so on load method call version does not matter. The version in store instrumentation is an aggregate version before store.
Instruments
load&storemethods. Tracks aggregate class, stream andfor storing also current aggregate version & number of events stored.