Subscriptions redesigned

ruby_event_store/lib/ruby_event_store/in_memory_subscriptions_store.rb

@@ -1,21 +1,57 @@
+# frozen_string_literal: true
+
 module RubyEventStore
+  # In memory subscriptions store
   class InMemorySubscriptionsStore
+    # Instantiates a new in memory subscriptions store
+    #
+    # @return [InMemorySubscriptionsStore]
     def initialize
-      @subscriptions = Hash.new {|hsh, key| hsh[key] = [] }
+      @subscriptions = Hash.new { |hsh, key| hsh[key] = [] }
     end
 
+    # Stores subscription in the store
+    # @param subscription [Subscription] subscription to store
+    # @param type [String, Class, GLOBAL_SUBSCRIPTION] a type of [Event]
+    #        or global subscription for for which subscription should be stored
+    #
+    # @return [self]
     def add(subscription, type = GLOBAL_SUBSCRIPTION)
       @subscriptions[type.to_s] << subscription
+      self
     end
 
+    # Removed subscription from the store
+    # @param subscription [Subscription] subscription to remove
+    # @param type [String, Class, GLOBAL_SUBSCRIPTION] a type of [Event]
+    #        or global subscription for for which subscription should be removed
+    #
+    # @return [self]
     def delete(subscription, type = GLOBAL_SUBSCRIPTION)
       @subscriptions.fetch(type.to_s).delete(subscription)
+      self
+    end
+
+    # Gets all subscriptions stored for given event type
+    # @param type [String, Class, GLOBAL_SUBSCRIPTION] a type of [Event]
+    #        or global subscription for which subscriptions should be returned
+    #
+    # @return [Array<Subscription>]
+    def all_for(type)
+      @subscriptions[type.to_s]
     end
 
-    def all_for(event_type)
-      @subscriptions[event_type.to_s]
+    # Gets all subscriptions stored
+    #
+    # @return [Array<Subscription>]
+    def all
+      @subscriptions.values.flatten.uniq
     end
 
+    # Gets this instance of subscription store
+    # Required for internal implementation of thread subscriptions
+    #
+    # @return [self]
     def value
       self
     end

ruby_event_store/lib/ruby_event_store/spec/subscription_store_lint.rb

@@ -0,0 +1,40 @@
+RSpec.shared_examples :subscription_store do |subscription_store|
+  FirstEvent = Class.new(RubyEventStore::Event)
+  SecondEvent = Class.new(RubyEventStore::Event)
+
+  specify do
+    expect(subscription_store.all).to eq []
+    expect(subscription_store.all_for(FirstEvent)).to eq []
+    expect(subscription_store.all_for(SecondEvent)).to eq []
+    expect(subscription_store.all_for(RubyEventStore::GLOBAL_SUBSCRIPTION)).to eq []
+
+    global = RubyEventStore::Subscription.new(-> { }, store: subscription_store)
+    first  = RubyEventStore::Subscription.new(-> { }, [FirstEvent], store: subscription_store)
+    second = RubyEventStore::Subscription.new(-> { }, [FirstEvent, SecondEvent], store: subscription_store)
+
+    expect(subscription_store.all).to match_array [global, first, second]
+
+    expect(subscription_store.all_for(FirstEvent)).to match_array [first, second]
+    expect(subscription_store.all_for(SecondEvent)).to match_array [second]
+    expect(subscription_store.all_for(RubyEventStore::GLOBAL_SUBSCRIPTION)).to match_array [global]
+
+    global.unsubscribe
+    expect(subscription_store.all_for(RubyEventStore::GLOBAL_SUBSCRIPTION)).to eq []
+    expect(subscription_store.all).to match_array [first, second]
+
+    first.unsubscribe
+    subscription_store.delete(first, FirstEvent)
+    expect(subscription_store.all_for(FirstEvent)).to match_array [second]
+    expect(subscription_store.all_for(SecondEvent)).to match_array [second]
+    expect(subscription_store.all).to match_array [second]
+
+    second.unsubscribe
+    expect(subscription_store.all_for(FirstEvent)).to eq []
+    expect(subscription_store.all_for(SecondEvent)).to eq []
+    expect(subscription_store.all).to eq []
+  end
+
+  specify "#value" do
+    expect(subscription_store.value).to eq(subscription_store)
+  end
+end

ruby_event_store/spec/in_memory_subscriptions_store_spec.rb

@@ -0,0 +1,8 @@
+require 'spec_helper'
+require 'ruby_event_store/spec/subscription_store_lint'
+
+module RubyEventStore
+  RSpec.describe InMemorySubscriptionsStore do
+    it_behaves_like :subscription_store, InMemorySubscriptionsStore.new
+  end
+end