Add AS::Notifications instrumentation #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it didn't have tests * wrong name * bad place to set the time * will be reintroduced when ready
This reverts commit fda6334.
…doesn't have to query before save.
… model" This reverts commit 2c9d551.
…ause AR doesn't have to query before save." This reverts commit aaa9b30.
…doesn't have to query before save
Require the railtie
Updated next DDD workshop date.
|
And it crashed mutant with |
Rails provides quite solid framework for logging/instrumentation. We could use it to provide better insight into event handling. Popular metric tools (Datadog, Librato) can already plug into that. One could also imagine plugging log subscriber for debugging purpose. http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html http://guides.rubyonrails.org/active_support_instrumentation.html#creating-custom-events This commit adds new dispatcher, only for RailsEventStore and makes it a default. The way a new default was baked into EventBroker was driven primarily by existing linters/shared_examples and mutant - likely to be refactored. Good enough for now to start discussion about relevance of this change.
mostlyobvious
force-pushed
the
as_notifications
branch
from
d3e518a
to
990e581
Compare
|
Reworked and reduced surface of changes - just another dispatcher in this PR, with little help of just released dispatcher lint. Changing default dispatcher could be another change, leaving intact now. Discussion still welcome! |
mostlyobvious
changed the title
Open
Still maintaining "describe" with class name so that mutant can match specs to changed code.
Allow logging/monitoring calls to #publish_event via AS::Notifications.
There's no other dispatcher in RailsEventStore namespace actually to name this one with specialized name.
|
Note to myself: check if error in subscriber of |
mlomnicki
reviewed
Aug 24, 2017
spec/client_spec.rb
Outdated
| @@ -13,6 +13,11 @@ module RailsEventStore | |||
| expect(client.__send__("event_broker")).to be_a EventBroker | |||
| end | |||
|
|
|||
| specify 'initialize proper dispatcher type' do | |||
| expect(EventBroker).to receive(:new).with(dispatcher: an_instance_of(Dispatcher)) | |||
There was a problem hiding this comment.
looks a bit useless. Is it needed because mutant complains otherwise?
|
it will be a super useful feature 👍 |
Unfortunately AS::Notifications does not swallow errors raised in subscribers and they're executed synchronously. An error in instrumentation poses a risk to rollback domain changes and event publication.
This was referenced Aug 29, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails provides quite solid framework for logging/instrumentation. We
could use it to provide better insight into event handling. Popular
metric tools (Datadog, Librato) can already plug into that.
One could also imagine plugging log subscriber for debugging purpose.
http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html
http://guides.rubyonrails.org/active_support_instrumentation.html#creating-custom-events
This commit adds new dispatcher, only for RailsEventStore and makes it a
default.
The way a new default was baked into EventBroker was driven primarily by
existing linters/shared_examples and mutant - likely to be refactored.
Good enough for now to start discussion about relevance of this change.