Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force SSL even for images #220

Closed
nodomain opened this issue Jul 1, 2014 · 3 comments
Closed

Force SSL even for images #220

nodomain opened this issue Jul 1, 2014 · 3 comments
Assignees

Comments

@nodomain
Copy link

nodomain commented Jul 1, 2014

Request for enhancement: implement a "proxy" that fetches images via the server and replace all image URLs in emails to HTTPS. This would avoid browser warnings.

@ervee
Copy link
Contributor

ervee commented Jul 1, 2014

Duplicate of #211?
Although this Bug is closed. I can't seem to figure out how to use the use_local_proxy_for_external_images setting. I tried to add it in the [labs] section of application.ini as:
use_local_proxy_for_external_images = On
or
use_local_proxy_for_external_images = True
or just
use_local_proxy_for_external_images
But nothing seems to enable the feature.

@RainLoop, could you please clarify if the feature you implemented for #211 is already usable?

I am +1 on this feature. It avoids Browser warning and give a little bit more privacy to the user.

@nodomain
Copy link
Author

nodomain commented Jul 1, 2014

Great! I'll update and have a look.

Am 01.07.2014 um 15:54 schrieb Ralf notifications@github.com:

Duplicate of #211?


Reply to this email directly or view it on GitHub.

@RainLoop RainLoop added this to the unknown milestone Jul 2, 2014
@RainLoop RainLoop self-assigned this Jul 2, 2014
@RainLoop RainLoop closed this as completed Jul 2, 2014
@colinjmatt
Copy link

For anyone wanting an answer to this (like I was) use_local_proxy_for_external_images = True works, but it requires the cache of the browser to be cleared for that setting to take effect if the images have already been downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants