Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

Closed
wants to merge 34 commits into from
Closed

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

wants to merge 34 commits into from

Conversation

the-djmaze
Copy link
Contributor

@the-djmaze the-djmaze commented Mar 16, 2020 •
edited

The changes in this branch converted all function calls in MailSo and RainLoop libraries to be PHP 7.3+ with type hinting.
Due to the massive changes i couldn't test all conversions yet (so it might be still broken and i'm fixing it).
I've also merged the latest changes since 1.4.0 (but password_hash is different due to PHP 7.3+).

It might work in PHP 7.2 (but that is in extended support 30 Nov 2020)

Most conversion is done by using the doc comments @param and @return and the param $b*, $s*, $i* but these seem to be broken while testing.
Like: "$s*" are bool or "@param string" are "@param string|null"
That's why it takes longer and i didn't create pull requests for documentation errors.

The current marked conflicts are only CRLF vs LF (my files don't use CRLF)

djmaze added 15 commits March 13, 2020 20:11
Bugfix: RainLoopFacebookRedirectLoginHelper should extend \Facebook\H…
f7ab900 
…elpers\FacebookRedirectLoginHelper
Classes to PHP 7.3+
eba6b28 
pclzip to ZipArchive
RainLoop and MailSo libraries @param, @return, etc. to PHP7.3+
c89a936 
This also includes:
* removal of PHP_VERSION 5.x checks
* use $_SERVER['REQUEST_TIME_FLOAT'] instead of APP_START and APP_START_TIME
* use admin password_hash

Keep in mind i couldn't test/resolve all potential bugs!
Fix PHP 7.4 Deprecate message
2849dde
Merge pull request RainLoop#1911 and RainLoop#1894
cf6a95d
Bugfix: @param/@return documentation was incorrect which caused errors
ac8fab0
Bugfix: mail Message invalid return type
8d5da92
Bugfix: more function return type errors
5aa2752
Removed function StripSlashesValue() because PHP7 has no magic_quotes…
8ba18c5 
…_gpc
Replaced &$o to $o as objects are always references
bb0183c 
Added more type hinting
Added support for PECL xxtea extension
2447668
Some static \NameSpace\Class:: to static::
fa0eb2f
Bugfix: xxtea_decrypt undefined $sString
529bc8a
Removed safe_mode
4de71b2
Speedup ImapClient partialParseResponseBranch() and partialResponseLi…
5cdf5b0 
…teralCallbackCallable()
@FlorianLaunay
Copy link

Hi @RainLoop . Do you plan to check this PR ? It will certainly resolve #1979 on PHP 7.4. Thank you @the-djmaze !

@the-djmaze
Copy link
Contributor Author

the-djmaze commented Apr 3, 2020 •
edited

Hi @RainLoop . Do you plan to check this PR ? It will certainly resolve #1979 on PHP 7.4. Thank you @the-djmaze !

Actually those are already solved a250d84

And this one when you use contacts 2bb947d

I also have more changes prepared (like: class \MailSo\Base\Collection extends \ArrayObject) which gives better memory management and speed.
But when these pulls are not approved i will keep them in my fork

@FlorianLaunay FlorianLaunay mentioned this pull request Apr 10, 2020
Closed
@phsc84
Copy link

phsc84 commented Jul 7, 2020

@the-djmaze Do you also provide a ZIP-package of your fork?
@RainLoop Would be great to merge this PR into the official repo!

@the-djmaze
Copy link
Contributor Author

the-djmaze commented Jul 10, 2020 •
edited

@the-djmaze Do you also provide a ZIP-package of your fork?
@RainLoop Would be great to merge this PR into the official repo!

Not at the moment.
Just pull the source of the php73 branch and upload the content of rainloop/v/0.0.0/ into your existing v1.4.0 to test it.

@phsc84
Copy link

phsc84 commented Jul 11, 2020

I have just tried, what you told me. Unfortunately I get the a blank page. The browser log (F12) shows the folllowing error:
www.abc.com/:1 GET https://www.abc.com/apps/mail/rainloop/v/1.14.0/static/js/min/polyfills.min.js?community net::ERR_ABORTED 404

djmaze added 2 commits July 13, 2020 10:54
Merge remote-tracking branch 'upstream/master' into php73
f4d989c 
# Conflicts:
#	rainloop/v/0.0.0/app/libraries/MailSo/Base/Crypt.php
#	rainloop/v/0.0.0/app/libraries/MailSo/Base/Utils.php
#	rainloop/v/0.0.0/app/libraries/MailSo/Mail/MailClient.php
#	rainloop/v/0.0.0/app/libraries/MailSo/Mime/Email.php
#	rainloop/v/0.0.0/app/libraries/MailSo/Mime/EmailDep.php
#	rainloop/v/0.0.0/app/libraries/MailSo/Sieve/ManageSieveClient.php
#	rainloop/v/0.0.0/app/libraries/RainLoop/Config/Application.php
#	rainloop/v/0.0.0/app/libraries/RainLoop/Service.php
#	rainloop/v/0.0.0/app/libraries/RainLoop/ServiceActions.php
#	rainloop/v/0.0.0/include.php
Upgrade to custom jQuery UI 1.12.1 due to errors with jQuery 3
a1257b8
@the-djmaze
Copy link
Contributor Author

the-djmaze commented Jul 15, 2020 •
edited

I have just tried, what you told me. Unfortunately I get the a blank page. The browser log (F12) shows the folllowing error:
www.abc.com/:1 GET https://www.abc.com/apps/mail/rainloop/v/1.14.0/static/js/min/polyfills.min.js?community net::ERR_ABORTED 404

You are correct!
Because there is no /rainloop/v/1.14.0/static/ you should use that from the original zip.
Else run npm install and gulp on my source.
And don't use my master branch, because that has stripped functionality.

@the-djmaze the-djmaze mentioned this pull request Oct 23, 2020
Closed
@rex2630
Copy link

rex2630 commented Jan 9, 2021

Idk why, but when i tried it, it didnt worked on PHP 8. Can u make a release or something? Because for me it stucked on blank screen...

@phsc84
Copy link

phsc84 commented Jan 9, 2021

Try Snappymail 2.1.1, a heavily updated fork of Rainloop. Snappymail is faster, lighter and much more futureproof (e.g. compatible with newer PHP versions).
https://github.com/the-djmaze/snappymail/releases

@rex2630
Copy link

rex2630 commented Jan 9, 2021

Most of the significiant functions that i really need are missing in there, so there is no chance of even trying.

@the-djmaze
Copy link
Contributor Author

Idk why, but when i tried it, it didnt worked on PHP 8. Can u make a release or something? Because for me it stucked on blank screen...

Blank screen means you can find the error in the php log.
I don't create releases, that's up to the RainLoop Team (or someone else).

Since the development of RainLoop is slow, i've moved on with SnappyMail.
I wonder which significant functions you are missing...

@rex2630
Copy link

rex2630 commented Jan 11, 2021

For example login via google, thats thing i cant be without

@the-djmaze the-djmaze mentioned this pull request Feb 1, 2021
Open
@the-djmaze the-djmaze closed this Mar 25, 2021
@the-djmaze the-djmaze deleted the php73 branch March 25, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@the-djmaze @FlorianLaunay @phsc84 @rex2630