Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price Factor or AutoCreateMinProfitPercent? #1036

Closed
acos0874 opened this issue Jun 7, 2020 · 2 comments
Closed

Price Factor or AutoCreateMinProfitPercent? #1036

acos0874 opened this issue Jun 7, 2020 · 2 comments
Assignees
@RainbowMiner
Labels
enhancement New feature or request implemented an enhancement has been implemented

Comments

@acos0874
Copy link

acos0874 commented Jun 7, 2020

I was mining swapcoin (low power algo) and I got some Kawpow rentals (high power algo), and the differences in power meant the margin for the MRR rental was not particularly high. Can the minprofitpercent be set to something so that it is based more on profit margins, than on revenue?
@RainbowMiner
Copy link
Owner

The AutoCreateMinProfitPercent is just a helper, to decide which rigs should be created at MRR. The announced price is calculated using the PriceFactor and/or PriceBTC values, based on revenue.
So, what we would need is a way to increase (or decrease) the announced price according to profit margins on a rig. I am already thinking about a solution, but would be happy for suggestions :)

@RainbowMiner RainbowMiner self-assigned this Jun 7, 2020
@RainbowMiner RainbowMiner added the enhancement New feature or request label Jun 7, 2020
RainbowMiner added a commit that referenced this issue Jun 7, 2020
@RainbowMiner
Update pool MiningRigRentals
ea2dd18 
- add pool parameters:
  - **PriceCostFactor**: Enter cost multiplicator (only in use if UsePowerPrice is enabled): minimum price = minimum price + (miner's cost - rig's average cost) x this multiplicator [default=1.0] (issue #1036)
  - **AutoUpdateMinPriceChangePercent**: Enter minimum price change in percent, for a rig's price to be updated on MRR [default=3]
@RainbowMiner
Copy link
Owner

RainbowMiner commented Jun 7, 2020 •
edited

Ok, I think I found a smart way to include the powerdraw differences into the MRR prices. The following parameter has been added to pools.config.txt/MiningRigRentals and mrr.config.txt:

  • PowerDrawFactor: Enter powerdraw multiplicator (only in use if UsePowerPrice is enabled): minimum price = minimum price + (miner's powerdraw - rig's average powerdraw) x 24/1000 x current powerprice x this multiplicator [default=1.0] (issue Price Factor or AutoCreateMinProfitPercent? #1036)

Also, I have added the price change level to the config (it has been unchangeable fixed 5% before):

  • AutoUpdateMinPriceChangePercent: Enter minimum price change in percent, for a rig's price to be updated on MRR [default=3]

@RainbowMiner RainbowMiner added the implemented an enhancement has been implemented label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RainbowMiner RainbowMiner

Labels
enhancement New feature or request implemented an enhancement has been implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RainbowMiner @acos0874