-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRR Autoextend #1057
Comments
An auto extend feature is actually a very nice idea. I'll add something like that. |
Thanks. It was only the autoextend option on that website. If I think of anything else I'll put it here. Does rbm already include a parameter for "relative to suggested"? How I used to implement my pricing to undercut the completion was use -20% relative to suggested but with a minimum price to make it more profitable than what I can make elsewhere (already implemented). This meant I could get rentals on less common algos like mtp whilst still maintaining a minimum on more common algos like ethash.
null
|
I think, the parameter "AutoPriceModifierPercent" (-30 .. 30) does this job. But there are two buts, currently. First, it's used during the creation of the rigs, only. Second, it's the same for all created rigs. Eventually, I could add either an extra parameter to pools.config.txt (like, "EnableAutoUpdateModifier", that would force the modifier being updated during updates, too), or I could add another config file (mrr.config.txt), which would contain all algorithm specific parameters (like that modifier) per algorithm (or probably both). |
Oh! Much easier! I could simply add those mrr parameters to the algorithms.config.txt - which in fact already contains per-algorithm parameters. |
- add parameter `"EnableUpdatePriceModifier": "0",` to pools.config.txt. Set to "1", if the price modifier should be automatically updated. The value is either global (pools.config.txt, parameters `"AutoPriceModifierPercent"` or specific for each algorithm (algorithms.config.txt parameter `"MRRPriceModifierPercent"`, if empty string, global value will be used) - issue #1057
|
Awesome, and just to check this will not override the minimum price which is also set by RBM? |
The minimum price will always be respected. |
I just had another thought about this. Autoextend might develop a risk of rig owners being short changed by renters using incorrect settings. For example, if the renter sets a too high difficulty it would make the hashrate percentage seem low, even though it's not the fault of the rig owner. The auto extend would mean the renter would unfairly be getting extra time for free. So a potential alternative or additional feature would be to notify the rig owner when the hashrate appears to be low, some time before the end of the rental and before autoextend. This would give the rig owner the choice of either manually intervening to extend the rental or letting autoextend do its thing. |
Yes, you are right. A malicious renter could cost us some nerves and money, here. It could be somehow limited by a value for "Max extend", but it could happen. |
True but in my experience it's more likely noob renters with incorrect settings.
null
|
Oh dear, I totally agree with you. |
Ok, auto extend on low average hashrate is added (commit c44395d)
Remarks:
|
I would also add a suggestion of adding extension option if possible. Adding an option to extend rental 1 hour for every 24 hour rented. |
I have implemented that feature yesterday :)
|
That is FAST! Thank you. |
He travelled back in time to implement it for you 😅 |
This value sets the "modifier" value at MiningRigRentals. It's a percentage increase/decrease of the MiningRigRental's suggested price. Using this value, you can under-/overbid other rig owners. It is also available per algorithm (in algorithms.config.txt), in there, the name of the parameter is "MRRUpdatePriceModifier". |
https://www.whattominingrigrentals.com/
This website uses an auto extend feature on the rentals
Unfortunately there is no way to 'mass edit' all rigs. I was wondering if you could please implement something similar in RBM?
The text was updated successfully, but these errors were encountered: