Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRR Rig Description in MRR.config #1062

Closed
acos0874 opened this issue Jun 17, 2020 · 10 comments
Closed

MRR Rig Description in MRR.config #1062

acos0874 opened this issue Jun 17, 2020 · 10 comments
Assignees
@RainbowMiner
Labels
enhancement New feature or request implemented an enhancement has been implemented

Comments

@acos0874
Copy link

Hi, I added custom descriptions for the rigs in this file but it doesn't seem to update the website. Did I maybe make them too long?
@RainbowMiner
Copy link
Owner

Actually, the description is not being updated, currently. I'll fix this.

RainbowMiner added a commit that referenced this issue Jun 17, 2020
@RainbowMiner
Update pool MiningRigRentals
5787d4d 
- add enable update rig descriptions (issue #1062)
  - **EnableUpdateDescription**: Enable automatic updating of rig descriptions (disable, if you prefer to edit your rig descriptions online at MRR) [default=1]
@RainbowMiner
Copy link
Owner

Ok, done.

  • add enable update rig descriptions:
    • EnableUpdateDescription: Enable automatic updating of rig descriptions (disable, if you prefer to edit your rig descriptions online at MRR) [default=1]

@RainbowMiner RainbowMiner self-assigned this Jun 17, 2020
@RainbowMiner RainbowMiner added enhancement New feature or request implemented an enhancement has been implemented labels Jun 17, 2020
@acos0874
Copy link
Author

acos0874 commented Jun 17, 2020 via email

@acos0874
Copy link
Author

The autoprice seems to be working but not the description updates. Is there a maximum length?

@RainbowMiner
Copy link
Owner

RainbowMiner commented Jun 18, 2020 •
edited

The autoprice seems to be working but not the description updates. Is there a maximum length?

I cannot say, but I'll ask. Also, I just remembered a conversation I had with merc (the mrr developer) regarding that description. The description cannot be updated via batch operations, which I am currently using to update the rigs. Eventually the updates can be solved pretty easy, if I switch to one-by-one updates, if a rig's description has changed. I'll give it a try.

RainbowMiner added a commit that referenced this issue Jun 18, 2020
@RainbowMiner
Update pool MiningRigRentals
8716bcd 
- one-by-one updates instead of batch update, if rig's description has changed (issue #1062)
@RainbowMiner
Copy link
Owner

That last update should help. I am testing, currently.

@RainbowMiner
Copy link
Owner

Too bad - that doesn't work, currently. I have forwarded the request for changeable descriptions to merc at MRR and disabled the new code, for the time being (c8a6437). There is a good chance, that merc will implement that feature.

RainbowMiner added a commit that referenced this issue Jun 18, 2020
@RainbowMiner
Update pool MiningRigRentals
98af79b 
- finally found a way to update rig's description (issue #1062)
@RainbowMiner
Copy link
Owner

Ha! Got it working, now. It's an undocumented API feature.

@acos0874
Copy link
Author

Awesome :)

@acos0874
Copy link
Author

Confirmed working. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RainbowMiner RainbowMiner

Labels
enhancement New feature or request implemented an enhancement has been implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RainbowMiner @acos0874