Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price factor using too long an average for MRR #1154

Closed
acos0874 opened this issue Sep 2, 2020 · 4 comments
Closed

Price factor using too long an average for MRR #1154

acos0874 opened this issue Sep 2, 2020 · 4 comments
Assignees
@RainbowMiner
Labels
enhancement New feature or request

Comments

@acos0874
Copy link

acos0874 commented Sep 2, 2020 •
edited

Sorry for all the issues. I've been monitoring my rig prices for a while and they don't seem to be behaving as expected. As an example, here is the profit and revenue on my 1660ti rig...

image

I then have the pricefactor set as "2".

These are some example rig prices.
Ethash
image

Kawpow
image

MTP
image

So they seem roughly correct but not exactly mulitplied by a factor of 2. Some others have mentioned this in discord. I can adjust the pricemodifier and this has the desired effect, but the minimum pricing doesn't seem to be working correctly for all algos. Ethash in particular.
@acos0874
Copy link
Author

acos0874 commented Sep 2, 2020

I deleted the mrr data file and it seemed to start working.

@acos0874
Copy link
Author

acos0874 commented Sep 2, 2020 •
edited

I've been mining solidly ethash on nicehash for the past day. Is the MRR base price for calculations based on a 3 hour average of earnings or 1 day average? Cos it seems the price factor is working but basing it off a much lower price than I'm actually earning. Could it possible due to reading the stable price instead of the actual price? Cos I was just looking at the ethash pool and there is quite a significant difference.

image

Perhaps because ethereum has been making big moves recently. I suspect it is using the 1 day average earnings because if I look in the profit stats I get this....

"Day": 0.000818292590073278

Which when multiplied by a price factor of 3 gives me 0.002454877770219834. And here is the my rig price using profit factor 3...

image

@acos0874 acos0874 changed the title Price factor not working Price factor using too long an average for MRR Sep 2, 2020
@RainbowMiner
Copy link
Owner

It indeed uses the one day average. I will add an extra parameter, so that the average base can be choosen.

@RainbowMiner RainbowMiner self-assigned this Sep 4, 2020
@RainbowMiner RainbowMiner added the enhancement New feature or request label Sep 4, 2020
RainbowMiner added a commit that referenced this issue Sep 4, 2020
@RainbowMiner
Update pool MiningRigRentals
ddc7881 
- add parameter "ProfitAverageTime" to pools.config.txt and mrr.config.txt (issue #1154). Adjust the device profit moving average time period to
  - Minute = 1 minute
  - Minute_5 = 5 minutes
  - Minute_10 = 10 minutes
  - Hour = 1 hour
  - Day = 1 day (=default)
  - ThreeDay = 3 days
  - Week = 1 week
@acos0874
Copy link
Author

acos0874 commented Sep 4, 2020

That's awesome. Just saw in the recent release. Thanks as ever!

@acos0874 acos0874 closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RainbowMiner RainbowMiner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RainbowMiner @acos0874