Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitSend (BSD) Bad Price #1384

Closed
shocker1185 opened this issue Feb 5, 2021 · 4 comments
Closed

BitSend (BSD) Bad Price #1384

shocker1185 opened this issue Feb 5, 2021 · 4 comments
Assignees
@RainbowMiner
Labels
bug Something isn't working solved An issue has been solved

Comments

@shocker1185
Copy link

RB Miner sees 1 BSD as 1 USD...wildly incorrect.
Thanks!
@RainbowMiner
Copy link
Owner

Wow! Yes, that's off. I will check the coins API

@RainbowMiner
Copy link
Owner

RainbowMiner commented Feb 5, 2021 •
edited

That's crazy: it is the Coinbase API that reports a value of 2658sat for 1BSD - our own API reports around 10sat for 1BSD.
I don't know, why the Coinbase value is so far off, but I will investigate.

EDIT: I think, I have found the culprit. Coinbase handles the two following coins:
image

.. obviously, they send BSD as "BasisDollar"

@RainbowMiner
Copy link
Owner

Even more different. The Coinbase's BSD is the Bahamian Dollar. I will implement a filter, so that all world currencies will be handled separately.

RainbowMiner added a commit that referenced this issue Feb 5, 2021
@RainbowMiner
Update core
8047324 
- rework coin rates to avoid clashes with world currencies and coin symbols (e.g. BSD, issue #1384)
@RainbowMiner RainbowMiner self-assigned this Feb 5, 2021
@RainbowMiner RainbowMiner added bug Something isn't working solved An issue has been solved labels Feb 5, 2021
@RainbowMiner
Copy link
Owner

Ok, I have reworked the coin rates functions, so that world currency vs. coin symbol clashes shouldn't happen any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RainbowMiner RainbowMiner

Labels
bug Something isn't working solved An issue has been solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shocker1185 @RainbowMiner