Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mintpond.ps1 estimated profit incorrect FIRO #1520

Closed
sxb1n9 opened this issue Mar 28, 2021 · 2 comments
Closed

Mintpond.ps1 estimated profit incorrect FIRO #1520

sxb1n9 opened this issue Mar 28, 2021 · 2 comments
Assignees
@RainbowMiner
Labels
pool issue solved An issue has been solved

Comments

@sxb1n9
Copy link
Contributor

sxb1n9 commented Mar 28, 2021

Mintpond returns wrong estimated profit at least for FIRO because of the following:

\Pools\Mintpond.ps1

Line 73 $reward = 14 #if ($lastBlock.reward) {$lastBlock.reward} else {14}

This should not be static 14 I believe FIRO reward is currently ~6.25
@RainbowMiner
Copy link
Owner

Thank you for reporting this. Mintpond had issues with the lastblock reward value back then. I'll rework the pool module.

@RainbowMiner RainbowMiner self-assigned this Mar 29, 2021
RainbowMiner added a commit that referenced this issue Mar 29, 2021
@RainbowMiner
Update pool Mintpond
9cfce70 
- fix reward calculation (issue #1520)
- remove BEAM
- remove defunct code
@RainbowMiner RainbowMiner added the solved An issue has been solved label Mar 29, 2021
@sxb1n9
Copy link
Contributor Author

sxb1n9 commented Mar 31, 2021

looks solved to me thank you.

@sxb1n9 sxb1n9 closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RainbowMiner RainbowMiner

Labels
pool issue solved An issue has been solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sxb1n9 @RainbowMiner