Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux version incorrectly detects Zen2 processor as AVX2 only #1803

Closed
PapaChealio opened this issue Nov 3, 2021 · 2 comments
Closed

Linux version incorrectly detects Zen2 processor as AVX2 only #1803

PapaChealio opened this issue Nov 3, 2021 · 2 comments
Assignees
Labels
bug Something isn't working hardware issue solved An issue has been solved

Comments

@PapaChealio
Copy link

Ubuntu 21.10
RBM 4.7.7.1
AMD Ryzen 3900x CPU

When GlobalCPUInfo.Features table is built in Modules/Include.psm1, the "sha_ni" CPU features flag is sanitized to become "shani". Regardless, neither flag is caught by miners, such as CpuminerJayddee, which look strictly for a "sha" flag as part of determining which binary version to use. In that example, "cpuminer-avx2" is used instead of the proper "cpuminer-zen".

..elseif($f.avx2 -and $f.sha -and $f.aes){'zen'}...

I suggest modifying the logic to be:

..elseif($f.avx2 -and ($f.sha -or $f.shani) -and $f.aes){'zen'}...

There may be a larger and/or more elegant fix required here to amalgamate all the "sha" flag variants into a single one to keep miner logic simple, but thought I'd point this out.

RainbowMiner added a commit that referenced this issue Nov 3, 2021
- fix new instruction set sha-ni/aes-ni detection (issue #1803)
@RainbowMiner RainbowMiner self-assigned this Nov 3, 2021
@RainbowMiner RainbowMiner added bug Something isn't working hardware issue solved An issue has been solved labels Nov 3, 2021
@RainbowMiner
Copy link
Owner

Thank you very much for letting me know! The problem is solved.

@PapaChealio
Copy link
Author

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hardware issue solved An issue has been solved
Projects
None yet
Development

No branches or pull requests

2 participants