Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging by spdlog #678

Merged
merged 2 commits into from
May 1, 2023
Merged

Add logging by spdlog #678

merged 2 commits into from
May 1, 2023

Conversation

RainerKuemmerle
Copy link
Owner

Instead of writing to stdout/stderr, the library now offers a logging layer to control the output in a better manner.

* Add wrapper classes to interface to spdlog
* Change text output to spdlog

Relates to #675
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #678 (adcf609) into master (e1281d0) will increase coverage by 0.19%.
The diff coverage is 22.30%.

❗ Current head adcf609 differs from pull request most recent head 2a7ea27. Consider uploading reports for the commit 2a7ea27 to get more accurate results

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   50.58%   50.78%   +0.19%     
==========================================
  Files         268      270       +2     
  Lines       10988    10951      -37     
==========================================
+ Hits         5558     5561       +3     
+ Misses       5430     5390      -40     
Impacted Files Coverage Δ
g2o/core/base_edge.h 80.85% <0.00%> (+1.68%) ⬆️
g2o/core/block_solver.hpp 42.68% <0.00%> (+0.12%) ⬆️
g2o/core/cache.cpp 50.57% <0.00%> (ø)
g2o/core/estimate_propagator.cpp 79.48% <ø> (ø)
g2o/core/factory.cpp 52.94% <0.00%> (+0.76%) ⬆️
g2o/core/hyper_dijkstra.cpp 87.71% <0.00%> (+1.51%) ⬆️
g2o/core/hyper_graph_action.cpp 42.40% <0.00%> (+0.33%) ⬆️
g2o/core/jacobian_workspace.cpp 100.00% <ø> (ø)
g2o/core/optimizable_graph.h 63.07% <ø> (ø)
g2o/core/optimization_algorithm_dogleg.cpp 66.91% <0.00%> (+0.48%) ⬆️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RainerKuemmerle RainerKuemmerle force-pushed the add_logging branch 2 times, most recently from adcf609 to a8ac5f7 Compare May 1, 2023 19:20
* Add setLevel function to control the logging level
* Add logger to solvers, types and core
* Fix for fmt >= 9.0.0
* Add G2O_USE_LOGGING cmake option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant