Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgbuild to build from source #1

Closed
wants to merge 1 commit into from
Closed

Fix pkgbuild to build from source #1

wants to merge 1 commit into from

Conversation

FabioLolix
Copy link

Hello, I have seen your pkgbuild on the AUR and it have several issues, here it is revisioned for building from downloaded source

  • from the AUR repo you can remove the readme and the license
  • corrected maintainer typing
  • following Arch Go packaging guidelines https://wiki.archlinux.org/title/Go_package_guidelines#Flags_and_build_options
  • go and libcaca are not needed as depends, go only as makedepends
  • downloaded sources are a binary, open source program need to build from source; otherwise re-upload pkgname-bin
  • never use sudo in pkgbuilds
  • about img2txt, please don't add not necessary stuff
PKGBUILD (kenbunshoku-haki) W: Non standard variable 'maintainer' doesn't start with an underscore
PKGBUILD (kenbunshoku-haki) W: Missing Maintainer tag
Checking kenbunshoku-haki-1.1-1-x86_64.pkg.tar.zst
kenbunshoku-haki W: ELF file ('usr/bin/kenbunshoku-haki') lacks FULL RELRO, check LDFLAGS.
kenbunshoku-haki W: ELF file ('usr/bin/kenbunshoku-haki') lacks PIE.
kenbunshoku-haki W: Dependency included, but may not be needed ('go')
kenbunshoku-haki W: Dependency included, but may not be needed ('libcaca')
Checking kenbunshoku-haki-1.1-1-x86_64.pkg.tar.zst
kenbunshoku-haki E: Dependency glibc detected and not included (libraries ['usr/lib/libc.so.6'] needed in files ['usr/bin/kenbunshoku-haki'])

@FabioLolix
Copy link
Author

I'm not going to rebase

@FabioLolix FabioLolix closed this Jun 26, 2023
@FabioLolix FabioLolix deleted the pkgbuild branch June 26, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant